Vicamo Yang [:vicamo][:vyang] Assignee
	Description • 11 years ago

From bug 864485 comment 31, let's move public native telephony DOM classes out of namesapce mozilla::dom::telephony to mozilla::dom while still keep private implementation details in it.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 1 • 11 years ago

* mozilla::dom - CallEvent.h, CallsList.h, Telephony.h, TelephonyCall.h, TelephonyCallGroup.h

* mozilla::dom::telephony - TelephonyCommon.h, TelephonyFactory.h, TelephonyChild.h, TelephonyParent.h

https://tbpl.mozilla.org/?tree=Try&rev=09dd8a1e5949

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 2 • 11 years ago

Comment on attachment 802257 [details] [diff] [review]
patch

Review of attachment 802257 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: dom/bindings/Bindings.conf
@@ +166,5 @@
>      'headerFile': 'BluetoothManager.h'
>  },
>  
>  'CallEvent': {
> +    'nativeType': 'mozilla::dom::CallEvent',

The default nativeType for 'Interface' is 'mozilla::dom::Interface', so I don't think you need any of these nativeType annotations anymore.

::: dom/telephony/TelephonyCallGroup.h
@@ +111,5 @@
>  
>    bool CanConference(const TelephonyCall& aCall, TelephonyCall* aSecondCall);
>  };
>  
> +} // namespace mozilla::dom

Just 'namespace dom'

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 3 • 11 years ago

Also unless Hsin-Yi is actually going to review this please remove her name from the commit message.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 4 • 11 years ago

Address previous comment.  Ask for hsinyi's review as well.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 5 • 11 years ago

Comment on attachment 802905 [details] [diff] [review]
patch : v2

Review of attachment 802905 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. But I am not a DOM peer and not able to review this. Remember to remove my name from the bug commit. Thank you.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 6 • 11 years ago

update r= only.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 7 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/2d38a1453c3d

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/2d38a1453c3d

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 9 • 11 years ago

You should probably remove the empty dicts from Bindings.conf.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 10 • 11 years ago

(In reply to :Ms2ger from comment #9)
> You should probably remove the empty dicts from Bindings.conf.

Filed as bug 922531.