Closed
Bug 910844
Opened 11 years ago
Closed 11 years ago
Allow Firefox Accounts jelly to check signed-in status and to sign out
Categories
(Firefox :: Sync, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: zaach, Assigned: zaach)
References
()
Details
(Whiteboard: [qa+])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
The jelly should be able to discover the signed-in status of the browser so it can show the appropriate UI. It should also be able to sign the user out.
We'll need to add a command handler to the wrapper for getting the user's signed in status and another handler for sign out.
Updated•11 years ago
|
Whiteboard: [qa+]
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #800285 -
Flags: feedback?(gavin.sharp)
Updated•11 years ago
|
Attachment #800285 -
Flags: feedback?(ttaubert)
Comment 2•11 years ago
|
||
Comment on attachment 800285 [details] [diff] [review]
Allow jelly to detect signed in status and sign user out
Looks pretty straightforward. Fat arrows would be a bit nicer (no bind()) but I don't feel strongly.
"data" as the return value of getSignedInUser is a bit ambiguous, it might be useful to elaborate on the data being passed via these messages in a comment.
In fact a higher-level description of messages that go back/forth and their format would be useful too. It's a bit confusing that the events in one direction have a "command" and "data", while in the other direction you have a "type" and "content" (which has a "status" and optionally "data").
Attachment #800285 -
Flags: feedback?(ttaubert)
Attachment #800285 -
Flags: feedback?(gavin.sharp)
Attachment #800285 -
Flags: feedback+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #800285 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #816801 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
And another!
Adding to my stack of Resolved bugs to review...
I expect the build will be on the ELM site by tomorrow morning...
Updated•11 years ago
|
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•