Closed
Bug 910877
Opened 11 years ago
Closed 11 years ago
Fix autoconf detection of math library functions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
As mentioned in bug 717379, the current autoconf checks for math library routines are failing to detect them in common cases. Attached is the patch to fix it, in a new bug.
Attachment #797461 -
Flags: review?(david.caabeiro)
Comment 1•11 years ago
|
||
Thank you for the patch Dan, it's much appreciated. May I ask you to flag this for review to jorendorff@mozilla.com instead? He's actually the one in charge of reviewing for this bug. Thanks!
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch
Ok, changing the review to :jorendorff.
Attachment #797461 -
Flags: review?(david.caabeiro) → review?(jorendorff)
Comment 3•11 years ago
|
||
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch
Bouncing to ted, who understands this stuff.
Attachment #797461 -
Flags: review?(jorendorff) → review?(ted)
Comment 4•11 years ago
|
||
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch
Review of attachment 797461 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry, I always have to refresh my memory when reviewing autoconf patches. This looks fine.
Attachment #797461 -
Flags: review?(ted) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•