Closed Bug 911022 Opened 11 years ago Closed 11 years ago

[e.me][feature] Enable search saving

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ranbena, Assigned: amirn)

References

Details

Attachments

(5 files, 1 obsolete file)

01_Search-Not-saved.png
(deleted), image/png
Details
02_Search-Not-saved-active.png
(deleted), image/png
Details
04_Search-Saved.png
(deleted), image/png
Details
05_Remove-Dialogue.png
(deleted), image/png
Details
redirect to PR
(deleted), text/html
crdlc
: review+
ranbena
: review+
Details
In search results, when searchbar is no longer focused, a star button should appear in the helper, indicating if the search already exists as a Collection in Homescreen. If it is not, clicking the star adds the new Collection to the Homescreen and notifies the user with a Banner.
Attached image 01_Search-Not-saved.png (deleted) —
Attached image 02_Search-Not-saved-active.png (deleted) —
Attached image 04_Search-Saved.png (deleted) —
Attached image 05_Remove-Dialogue.png (deleted) —
Attached file Patch - redirect to commit.html (obsolete) (deleted) —
Attachment #797680 - Flags: review?(amirn)
Blocks: 910343
Assignee: nobody → amirn
Blocks: 1.3-e.me
Attached file redirect to PR (deleted) —
Attachment #797680 - Attachment is obsolete: true
Attachment #797680 - Flags: review?(amirn)
Attachment #811705 - Flags: review?(crdlc)
Attachment #811705 - Flags: review?(ran)
You have some comments on github
Status: NEW → ASSIGNED
(In reply to Cristian Rodriguez (:crdlc) from comment #8) > You have some comments on github Thanks Crisitan. update PR: replaced callbacks with events. can you give it another look please?
Comment on attachment 811705 [details] redirect to PR Two minor comments on github. Good work as usual! Thx!
Attachment #811705 - Flags: review?(crdlc) → review+
I put some comments on Github Amir
ready for your re-review ran@everything.me
Attachment #811705 - Flags: review?(ran) → review+
safely landed in master https://github.com/mozilla-b2g/gaia/commit/41fd4bd65cc5760f1e264e8ab8b1631f5284f1a3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: