Closed
Bug 911053
(activity-window)
Opened 11 years ago
Closed 11 years ago
[fugu][Window Management] Implement Activity Window
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(blocking-b2g:fugu+)
RESOLVED
FIXED
blocking-b2g | fugu+ |
People
(Reporter: alive, Assigned: alive)
References
Details
Attachments
(2 files, 1 obsolete file)
Currently Activity is managed in Window Manager.
We would like to implement an OO class "Activity Window",
which inherits from AppWindow class.
And then remove the startInlineActivity and stopInlineActivity from WindowManager.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Proposed Multi chaining activity model
https://docs.google.com/drawings/d/1I3Fvg1PHuft82rxBl0ITTpl2HGcdiN1fxPc5qhIqFHw/edit?usp=sharing
Assignee | ||
Comment 3•11 years ago
|
||
WIP today,
https://github.com/alivedise/gaia/commit/c76c23a6a85be88dfda73e446524c27f7886dc6d
Nearly done, need to improve test.
Assignee | ||
Comment 4•11 years ago
|
||
I found getIconSplash is broken in activity(current), file another bug to track.
Assignee | ||
Comment 5•11 years ago
|
||
Also current orientation strategy of activity is not perfect, file another bug to refine.
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
Implement ActivityWindow
Implement ActivityWindowFactory
New VisibilityManager
New OrientationManager
Unit Tests
Attachment #821019 -
Flags: review?(timdream)
Updated•11 years ago
|
Attachment #821019 -
Flags: review?(timdream) → review+
Assignee | ||
Updated•11 years ago
|
Blocks: activity-management
Assignee | ||
Comment 8•11 years ago
|
||
Part.2
https://github.com/alivedise/gaia/commit/b289bded15764013f8c54ac31653cab7b84f61b1
Implement AppModalDialog + BaseUI
Refine logging
Remove invalid tests
Travis is green except test_bookmark.
https://travis-ci.org/mozilla-b2g/gaia/builds/13080095
Attachment #821019 -
Attachment is obsolete: true
Attachment #822750 -
Flags: review?(timdream)
Updated•11 years ago
|
Component: Gaia::System → Gaia::System::Window Mgmt
Updated•11 years ago
|
Attachment #822750 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Sent an email to qa-b2g@mozilla.com, if no response today I will land this. (Still trying to find out significant issues)
Comment 10•11 years ago
|
||
(In reply to Alive Kuo [:alive] from comment #9)
> Sent an email to qa-b2g@mozilla.com, if no response today I will land this.
> (Still trying to find out significant issues)
Sorry for the lack of response - let me ping the tw-qa guys to help out.
Assignee | ||
Comment 11•11 years ago
|
||
Thanks!
(In reply to Jason Smith [:jsmith] from comment #10)
> (In reply to Alive Kuo [:alive] from comment #9)
> > Sent an email to qa-b2g@mozilla.com, if no response today I will land this.
> > (Still trying to find out significant issues)
>
> Sorry for the lack of response - let me ping the tw-qa guys to help out.
Assignee | ||
Comment 12•11 years ago
|
||
Travis is green finally.
https://travis-ci.org/mozilla-b2g/gaia/builds/13322148
Assignee | ||
Comment 13•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 14•11 years ago
|
||
You inverted the aria-hide attribute. It should be the other way around, when we unlock, aria-hidden should be false.
Assignee | ||
Updated•11 years ago
|
Blocks: task-manager
Assignee | ||
Updated•11 years ago
|
No longer blocks: task-manager
Assignee | ||
Updated•11 years ago
|
Alias: activity-window
Updated•11 years ago
|
blocking-b2g: --- → fugu?
Summary: [Window Management] Implement Activity Window → [fugu][Window Management] Implement Activity Window
Assignee | ||
Comment 15•11 years ago
|
||
What is this change for?
Comment 16•11 years ago
|
||
James,
The bugs(such as 937508 ,938090) related to activity window are already fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?
Flags: needinfo?(james.zhang)
Comment 17•11 years ago
|
||
(In reply to pcheng from comment #16)
> James,
> The bugs(such as 937508 ,938090) related to activity window are already
> fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?
v1.3 is ok. Thanks!
Flags: needinfo?(james.zhang)
Comment 18•11 years ago
|
||
(In reply to pcheng from comment #16)
> James,
> The bugs(such as 937508 ,938090) related to activity window are already
> fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?
Oh, sorry, we should merge it back to v1.2. It cause several major bugs in our bugzilla.
Updated•11 years ago
|
Flags: needinfo?(styang)
Updated•11 years ago
|
blocking-b2g: fugu? → fugu+
Flags: needinfo?(styang)
Updated•11 years ago
|
Whiteboard: [Fugu need]
Updated•11 years ago
|
Whiteboard: [Fugu need] → [Fugu needs]
Comment 19•11 years ago
|
||
Alive,
Why is this needed in fugu?
Can it wait till 1.4?
Flags: needinfo?(alive)
Assignee | ||
Comment 20•11 years ago
|
||
It's not me setting fugu stuff. I have the same question and I tend to modify the title back.
Flags: needinfo?(alive)
Comment 21•11 years ago
|
||
Updated•11 years ago
|
Attachment #8346440 -
Flags: review?(ehung)
Comment 23•11 years ago
|
||
Comment on attachment 8346440 [details] [diff] [review]
911053.patch
I have no idea why you submit a patch for a refactoring issue which has been resolved. Please note this bug isn't for a specific bug but a piece of window manager refactoring stuff. I know this work indirectly resolves some issues happen on fugu, but we can't uplift (because a bunch of dependency) nor accept workaround patch here.
For those issues (indirectly resolved by this bug) on v1.2, we decided to resolve them separately. They are tracking in bug 949854 and bug 949860. Please check them out.
Attachment #8346440 -
Flags: review?(ehung) → review-
Comment 24•11 years ago
|
||
To confirm, this commit does not uplift cleanly to v1.2f. As stated in comment 22, someone will need to adapt the patch for this branch.
Updated•11 years ago
|
Flags: needinfo?(styang)
Whiteboard: [Fugu needs]
You need to log in
before you can comment on or make changes to this bug.
Description
•