Closed
Bug 911767
Opened 11 years ago
Closed 11 years ago
[e.me][bug] Long press on pinned cloud apps doesn't toggle edit mode
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ranbena, Assigned: amirn)
References
Details
(Keywords: regression, Whiteboard: burirun1, burirun2 [NO_UPLIFT])
Attachments
(2 files)
Long pressing any pinned app should toggle edit mode.
|
Reporter | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•11 years ago
|
||
pushed to branch 911767-cloudapps-editmode
https://github.com/EverythingMe/gaia/commit/f711c87531df6a3aeb55ca6dba0020cea14541f5
|
|
Reporter | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
|
Reporter | |
Comment 2•11 years ago
|
||
Attachment #800099 -
Flags: review?(crdlc)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 800099 [details]
Patch - redirect to github PR
Good job, thanks
Attachment #800099 -
Flags: review?(crdlc) → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
Landed in master
https://github.com/mozilla-b2g/gaia/commit/552587d0802c0a582fdb487201bb70e3ce4af359
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•11 years ago
|
||
Vivien asked to revert all recent v1.2 commits.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 6•11 years ago
|
||
Just making a note that this appears to be backed out here: https://github.com/mozilla-b2g/gaia/commit/83c9c656955611bc28205511050ed6cb5ad7b4e5
|
||
Updated•11 years ago
|
Whiteboard: burirun1
|
||
Updated•11 years ago
|
Keywords: regression
|
|
Assignee | |
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•11 years ago
|
||
Added to stg-pr branch
|
|
Reporter | |
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•11 years ago
|
||
This PR is only a rebase to master
Attachment #811713 -
Flags: review?(crdlc)
|
|
||
Updated•11 years ago
|
Attachment #811713 -
Flags: review?(crdlc) → review+
|
|
||
Comment 9•11 years ago
|
||
Set obsolete patches
|
|
Assignee | |
Comment 10•11 years ago
|
||
landed in master
https://github.com/mozilla-b2g/gaia/commit/f1cdfdd322fdd94a5fffcba8483f284f82d23e3c
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
|
||
Comment 11•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.2
git cherry-pick -x -m1 f1cdfdd322fdd94a5fffcba8483f284f82d23e3c
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(amirn)
|
|
||
Comment 12•11 years ago
|
||
Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.
Whiteboard: burirun1, burirun2 → burirun1, burirun2 [NO_UPLIFT]
|
|
Assignee | |
Comment 14•11 years ago
|
||
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi+ → ---
Flags: needinfo?(amirn)
You need to log in
before you can comment on or make changes to this bug.
Description
•