Brian Grinstead [:bgrins] Reporter
	Description • 11 years ago

If you click on a script or link tag with no content inside of the markup view, there is no twisty arrow by it to expand, but if you press the right arrow it will expand anyway.  It should not do this.

	mjh563
	Comment 1 • 11 years ago

This short patch seems to fix it. Do you think this is right?

	Brian Grinstead [:bgrins] Reporter
	Comment 2 • 11 years ago

Comment on attachment 799776 [details] [diff] [review]
patch: only expand containers that have children

Review of attachment 799776 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, but pbrosset should have a look at it, as he may have some related work in Bug 855523

	Patrick Brosset <:pbro> Assignee
	Comment 3 • 11 years ago

I think it makes more sense to add this logic at the `_onKeyDown` level:

  ...
  case Ci.nsIDOMKeyEvent.DOM_VK_RIGHT:
    if (!this._selectedContainer.expanded && this._selectedContainer.hasChildren) {
      this._expandContainer(this._selectedContainer);
    }
  ...

I've had cases where the promise returned by `this._updateChildren(aContainer, true)` wasn't waiting for children to be ready, and therefore the `if (this.hasChildren)` in your code wouldn't expand on these nodes.

For information, the markup-view will change quite a lot when bug 855523 lands, so we might want to hold back a bit for this one.

	mjh563
	Comment 4 • 11 years ago

OK, so it seems as though I was a bit premature with the patch. :)

Unassigning myself for now.

	Patrick Brosset <:pbro> Assignee
	Comment 5 • 11 years ago

I confirm that this bug has been fixed via bug 855523 which just landed.