[:fabrice] Fabrice Desré Assignee
	Description • 11 years ago

We want to make sure that apps updates are checked daily, but they are currently tied to system update checks. Unfortunately this fails in the following situation:
- System updates are disabled because a partner is using its own ota platform.
- The default interval is set to something different, like a week.

	[:fabrice] Fabrice Desré Assignee
	Comment 1 • 11 years ago

This patch moves the app updates checks to their own component, and use its own timer if the system update timer is disabled or set to a non-daily interval.

I'm currently running end-to-end tests with metrics to make sure we get the pings in various situations.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 2 • 11 years ago

Comment on attachment 799669 [details] [diff] [review]
patch v1

Let's see if Etienne wants to review this.

	[:fabrice] Fabrice Desré Assignee
	Comment 3 • 11 years ago

Logs check with metrics look good. This is a cleaned up version of the previous patch.

	Etienne Segonzac (:etienne)
	Comment 4 • 11 years ago

Comment on attachment 801057 [details] [diff] [review]
patch v2

Review of attachment 801057 [details] [diff] [review]:
-----------------------------------------------------------------

All good and completely transparent to gaia.

Picked up a few things along the way :)

::: b2g/components/B2GComponents.manifest
@@ +77,5 @@
> +
> +# WebappsUpdateTimer.js
> +component {637b0f77-2429-49a0-915f-abf5d0db8b9a} WebappsUpdateTimer.js
> +contract @mozilla.org/b2g/webapps-update-timer;1 {637b0f77-2429-49a0-915f-abf5d0db8b9a}
> +category update-timer WebappsUpdateTimer @mozilla.org/b2g/webapps-update-timer;1,getService,background-update-timer,webapps.update.interval,86400

this is cool.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 5 • 11 years ago

Comment on attachment 801057 [details] [diff] [review]
patch v2

rubberstamp r+

	[:fabrice] Fabrice Desré Assignee
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/564f0718eefe

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/564f0718eefe