Closed
Bug 912748
Opened 11 years ago
Closed 11 years ago
Geolocation crashes Nightly and Aurora running on Froyo
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox25- wontfix, firefox26- fixed, fennec+)
RESOLVED
FIXED
Firefox 26
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
(deleted),
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
Fennec is calling GsmCellLocation.getPsc() which was added in Gingerbread:
https://developer.android.com/reference/android/telephony/gsm/GsmCellLocation.html#getPsc%28%29
We need a version check for Froyo. All the other GsmCellLocation methods are supported by Froyo; we just want to skip getPsc().
Assignee | ||
Comment 1•11 years ago
|
||
This code path is (currently) #ifdef'd for just the Nightly and Aurora channels, so Beta and Release users are unaffected.
Comment 2•11 years ago
|
||
STR:
- Install nightly on your android
- Go to maps.google.com
- Ask to be geolocated
- See nightly crash.
Here are the logs from adb logcat:
E/AndroidRuntime( 973): FATAL EXCEPTION: Thread-9
E/AndroidRuntime( 973): java.lang.NoSuchMethodError: android.telephony.gsm.GsmCellLocation.getPsc
E/AndroidRuntime( 973): at org.mozilla.mozstumbler.Scanner.getCellInfo(Scanner.java:264)
E/AndroidRuntime( 973): at org.mozilla.mozstumbler.Scanner.onLocationChanged(Scanner.java:227)
E/AndroidRuntime( 973): at android.location.LocationManager$ListenerTransport._handleMessage(Locat
ionManager.java:191)
E/AndroidRuntime( 973): at android.location.LocationManager$ListenerTransport.access$000(LocationM
anager.java:124)
E/AndroidRuntime( 973): at android.location.LocationManager$ListenerTransport$1.handleMessage(Loca
tionManager.java:140)
E/AndroidRuntime( 973): at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 973): at android.os.Looper.loop(Looper.java:144)
E/AndroidRuntime( 973): at org.mozilla.mozstumbler.ScannerService$LooperThread.run(ScannerService.
java:110)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [good first bug][lang=java][mentor=cpeterson]
Updated•11 years ago
|
tracking-fennec: --- → ?
status-firefox25:
--- → affected
status-firefox26:
--- → affected
tracking-firefox25:
--- → ?
tracking-firefox26:
--- → ?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Whiteboard: [good first bug][lang=java][mentor=cpeterson]
Assignee | ||
Comment 3•11 years ago
|
||
GsmCellLocation.getPsc() is only supported on GB+.
Attachment #800348 -
Flags: review?(blassey.bugs)
Updated•11 years ago
|
Attachment #800348 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
I don't think we need to track (or uplift) this fix for Aurora 25. This Froyo crashing feature is #ifdef'd only for the Nightly and Aurora channels. Nightly 26 will be promoted to Aurora in about one week and then both Nightly and Aurora will be fixed (and the feature will still be #ifdef'd off in Beta).
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•11 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•