Closed Bug 912809 Opened 11 years ago Closed 11 years ago

scrollIntoView(true) results in a broken test state

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: jlal, Assigned: jlal)

References

Details

Attachments

(2 files)

I ran into this same problem when working on the "auto focus" forms feature in b2g where scrollIntoView(true) would put the device in a broken scroll state ( will attach an image ). Is there some rational that makes true better then false? If not false works better... Sadly I don't have background why it is this way yet.
Attached patch turn scrollIntoView to false (deleted) — Splinter Review
Attachment #799901 - Flags: feedback?(jgriffin)
Image example- this can happen in other cases... I will try to figure out what causes this and hopefully file a bug to either fix this or write a marionette server test to cover the case.
Malini or David could likely answer this better than I.
Flags: needinfo?(dburns)
Comment on attachment 799901 [details] [diff] [review] turn scrollIntoView to false Review of attachment 799901 [details] [diff] [review]: ----------------------------------------------------------------- Just intuitively, this change makes sense. I'm going to make a try run and see what happens.
Attachment #799901 - Flags: feedback?(jgriffin) → feedback+
Blocks: 892519
This patch didn't apply cleanly, which resulted in a no-op try run. I've fixed that, and pushed to try again: https://tbpl.mozilla.org/?tree=Try&rev=922e6cb74eb6
try run is green, let's ship it!
https://hg.mozilla.org/integration/mozilla-inbound/rev/cca8f2b78300 Hopefully this won't impact gaia-ui-tests, but cc'ing WebQA in case it does.
Flags: needinfo?(dburns)
Assignee: nobody → jlal
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: