Today, we don't show the warnings if there are errors.

Comment on attachment 825073 [details] [diff] [review] Display warnings and errors if both are present I think there's more than that: - warnings checks are not always run when there's an error (for example, use a manifest without a name and without an icon, we should have an error + a warning, but the warning check is not run because of a `return null` in app-validator.js) - we should display warning messages if there are errors

(In reply to Paul Rouget [:paul] from comment #2) > Comment on attachment 825073 [details] [diff] [review] > Display warnings and errors if both are present > > I think there's more than that: > > - warnings checks are not always run when there's an error (for example, use > a manifest without a name and without an icon, we should have an error + a > warning, but the warning check is not run because of a `return null` in > app-validator.js) Good call, I'll remove those cases so that validator will still proceed. > - we should display warning messages if there are errors That does indeed happen with this current patch. :P

Some small style cleanups that JSHint pointed out in the validator file.

This is the same patch you reviewed previously, just rebased and named "Part 2". I was already displaying both warnings and errors if the validator stored both of them, so no changes were needed there.

This allows the manifest to keep continue validating even if the name is missing. That's actually the only one I saw that can be changed... All of the other "return null" paths are for real problems, like not having a manifest at all, or it has bad syntax.

Try: https://tbpl.mozilla.org/?tree=Try&rev=799a45eb43cb

Comment on attachment 827095 [details] [diff] [review] Part 2: Display warnings and errors if both are present > + -moz-margin-start: 10px; Why? We're not supposed to support bidi in projects.xhtml.

Rebased, carrying over Paul's r+ from attachment 827094 [details] [diff] [review].

Carrying over Paul's r+ from attachment 827095 [details] [diff] [review]. (In reply to Paul Rouget [:paul] from comment #9) > Comment on attachment 827095 [details] [diff] [review] > Part 2: Display warnings and errors if both are present > > > + -moz-margin-start: 10px; > > Why? We're not supposed to support bidi in projects.xhtml. Good to know. Changed to margin-left.

https://hg.mozilla.org/integration/fx-team/rev/763edcbd5757 https://hg.mozilla.org/integration/fx-team/rev/0b7c44eff352 https://hg.mozilla.org/integration/fx-team/rev/45b199e32b8e

Backed out for test_app_validator.html timeouts. https://hg.mozilla.org/integration/fx-team/rev/8401f783b9f0 https://tbpl.mozilla.org/php/getParsedLog.php?id=30288914&tree=Fx-Team

Carrying over Paul's r+ from attachment 827098 [details] [diff] [review]. Seems I forgot to add the test files. Try: https://tbpl.mozilla.org/?tree=Try&rev=765f22fd590d

https://hg.mozilla.org/integration/fx-team/rev/74303a630bea https://hg.mozilla.org/integration/fx-team/rev/b5bb24894892 https://hg.mozilla.org/integration/fx-team/rev/9bfc039b9262

https://hg.mozilla.org/mozilla-central/rev/74303a630bea https://hg.mozilla.org/mozilla-central/rev/b5bb24894892 https://hg.mozilla.org/mozilla-central/rev/9bfc039b9262