Closed Bug 912957 Opened 11 years ago Closed 11 years ago

Film strip not visible after taking a video

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 916220

People

(Reporter: Bebe, Unassigned)

References

Details

(Keywords: regression)

Attachments

(3 files)

STR: 1. Open the camera app 2. Tap video icon 3. Tap the video icon to record a video 4. Tap again to stop the video recording 5. Wait for the film strip Expected: 5. The film strip should be displayed in a short time Actual: 5. The film strip is not displayed Reproducing this on: Gecko http://hg.mozilla.org/mozilla-central/rev/7ff96bd19c1c Gaia b6c5bf1d24230bfed4a8f680e625fa2175001f82 BuildID 20130904040205 Version 26.0a1 This test first to failed on build: http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.mozril.gaia.master.ui/159
Attached file logcat of the issue (deleted) —
this is not 100% reproducible but I can see it 80% of the cases
Dave, any recent changes in DeviceStorage?
Flags: needinfo?(dhylands)
The most recvent device storage change that I was involved with was about volume state changes (bug 878310) but that landed on master on Aug 23.
Flags: needinfo?(dhylands)
When did automated test last pass? When did it first fail?
blocking-b2g: --- → koi?
Need info for comment 5
Flags: needinfo?(zcampbell)
Ah, missed the last piece of comment 0. The regression window here is: - First fail: Date - 9/4/2013 - Last pass: Date - 9/3/2013
Flags: needinfo?(zcampbell)
Does it still fail now?? I have a working version 20130912040201.
Flags: needinfo?(jsmith)
BTW, I had tested with the same version 20130904040205 in Inari. It works.
There was a related issue in bug 893019, which was fixed back in July. If we're not seeing this issue in current builds, we can close it.
(In reply to John Hu [:johnhu] (PTO Sept. 19 ~ 22) from comment #8) > Does it still fail now?? > > I have a working version 20130912040201. Bebe - Can you check if this Gaia UI test passes now on today's build?
Flags: needinfo?(jsmith) → needinfo?(florin.strugariu)
jsmith I have only a Unagi available and I'm blocked by bug 915697 so I can't use any master build. I will check it when we will be able to flash a Unagi with master
Owing to the broken Unagi build (comment #12) I tested this on the Inari device and it is still not fixed. Device Inari Gecko http://hg.mozilla.org/mozilla-central/rev/1d27c4c9871f Gaia 1518b76c07c4d70fc41113ed2e424a74b2bcef27 BuildID 20130917040201 Version 26.0a1
Flags: needinfo?(florin.strugariu)
(In reply to Zac C (:zac) from comment #13) > > Owing to the broken Unagi build (comment #12) I tested this on the Inari > device and it is still not fixed. > > Device Inari > Gecko http://hg.mozilla.org/mozilla-central/rev/1d27c4c9871f > Gaia 1518b76c07c4d70fc41113ed2e424a74b2bcef27 > BuildID 20130917040201 > Version 26.0a1 That m-c hash is changeset 147371; I do not see this issue on hamachi with m-c changeset 147326 (hash dc909122bcf5), so there's a potential regression window.
Running hamachi with m-c:1d27c4c9871f (from comment 14, above) starting and stopping a recording does not cause the filmstrip to appear; also, the viewfinder is frozen as in bug 916220. With the patch in that bug applied, video recording works properly and the filmstrip appears when recording is done.
I can reproduce it with the same version mentioned by Zac at comment 12. Once a recording is made, I can't use camera anymore.
Assignee: nobody → johu
Attached video broken video file (deleted) —
This attachment is recorded by camera. It is not playable. After doing more tests, I found the following symptom: 1. The file looks like containing incomplete video data. We should have a file above 1 MB. Dumping metadata of this file with ffmpeg got: [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7ff4db022800] moov atom not found VID_0004.3gp: Invalid data found when processing input 2. When stopping recording, device storage doesn't dispatch the "change" event to camera app. This may be caused by the symptom 1. 3. We can't have a workable camera anymore. When we killed camera app and opened it again, we can't get the callback called with mozCameras.getCamera()[1]. The only way to have a workable camera is to reboot the phone. [1] https://github.com/mozilla-b2g/gaia/blob/2c3dc472094a278da97d43e7cfe0b6d2a075b24c/apps/camera/js/camera.js#L947
I will assign to myself again when we need gaia patch.
Assignee: johu → nobody
Sorry, one thing missed. The viewfinder is frozen when recording, like comment 15.
(In reply to John Hu [:johnhu] (PTO Sept. 19 ~ 22) from comment #19) > > Sorry, one thing missed. The viewfinder is frozen when recording, like > comment 15. John, the patch for bug 916220 landed in m-c yesterday afternoon PDT. If your test build didn't have this fix, please try with a newer build/pull.
QA Contact: mozillamarcia.knous
Discussed during media triage today. Was asked to test on the latest 1.2 build and I still see this behavior on Buri using: Gaia 9b1b262e8fde58be453fb05ed91c0e93ab86d394 SourceStamp 0322470077b7 BuildID 20130918004001 Version 26.0a2 The bug is not present on the latest Mozilla Central build.
Attached file 910498_video_thumbnail (deleted) —
Same issue I faced in the Nexus-4 devices, it is due to createThumbnail. The Video element graphics buffer format is 'HAL_PIXEL_FORMAT_YCbCr_420_SP_TILE'. This is not implemented in GrallocImages.cpp. Color conversion is implemented from YUV420 to RGB for 'YCbCr_420_SP_TILE' and Fixed this problem Now i could see the Flimstrip in Video recording for few seconds.
(In reply to saminath from comment #22) > Created attachment 807708 [details] > 910498_video_thumbnail > > Same issue I faced in the Nexus-4 devices, it is due to createThumbnail. The > Video element graphics buffer format is > 'HAL_PIXEL_FORMAT_YCbCr_420_SP_TILE'. This is not implemented in > GrallocImages.cpp. Nexus-4's one is different problem. It is tracked in Bug 911548.
This should be fixed on b2g as of bug 916220 comment 7. Marcia, if you can confirm, we can close this as a dupe.
Flags: needinfo?(mozillamarcia.knous)
Duping to the bug in Comment 23. This works fine using today's 1.2 build.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(mozillamarcia.knous)
Resolution: --- → DUPLICATE
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: