Bug 855523 was used to re-work the markup view in a way that nodes would be easily expanded and collapsed. This bug should bring the same to the computed styles view. This view has no edition capabilities, so the expand/collapse functionality can easily be expanded to the whole row instead of being limited to the twisty icon.

In order to work like the markup view does, I propose to keep the single click toggling on the twisty icon, and add a double click toggling on the rest of the style container.

Work in progress. Missing a test for the dblclick, which I can't get to work. Heather, would you mind taking a look and let me know what I'm doing wrong with the EventUtils lib? Thanks.

I managed to make the double click test working. So attaching a new patch, rebased, ready for review.

Patrick, I'm trying out this patch, and clicking the row doesn't seem to expand it. Is that functionality in this patch?

See comment 1, this bug aims at bringing the same level of functionality as the markup view does, that is: - single click on twisty - double click on the container itself. So you should try to double click instead. Cheers

Comment on attachment 802261 [details] [diff] [review] 913014-computed-view-toggle.patch Review of attachment 802261 [details] [diff] [review]: ----------------------------------------------------------------- Aha, sorry. This looks good, thanks!

Thanks Heather for the review. This patch is a week old and will need some merging with bug 835808 when it lands, so I'll hold it for now and rebase/merge and re-attach the patch when done.

Attaching a new version of the patch: - Merged with 835808 that landed in fx-team a couple of days ago. - Rebased with the latest fx-team.

Pushed to TRY once more for good measure: https://tbpl.mozilla.org/?tree=Try&rev=9c161d2b7891

TRY all green!