Closed
Bug 913366
Opened 11 years ago
Closed 11 years ago
Improve strings and l10n comment in app-manager.properties
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
The current file is completely missing localization comments and has at least 2 strings with problems.
validator.invalidManifestJSON=The webapp manifest isn't a valid JSON file: %1$S at: %2$S
If I read the code right, variable should be swapped (%1$S is the url, %2$S the error message).
validator.missIconForMarketplace=app submission to the Marketplace needs at least an 128 icon
"an 128 icon" doesn't sound right to me, I guess adding pixel would make sense too.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #800640 -
Flags: review?(paul)
|
||
Comment 2•11 years ago
|
||
Attachment #800640 -
Flags: review?(paul) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [land-in-fx-team][fixed-in-fx-team]
|
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team][fixed-in-fx-team] → [fixed-in-fx-team]
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•