Closed Bug 913464 Opened 11 years ago Closed 11 years ago

Tabstrip overflow arrow button borders, pinned tab glow, and separators overlap the navbar

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Keywords: regression, Whiteboard: [Australis:M-][Australis:P-])

Attachments

(3 files)

arrow-separator-overlap.png
(deleted), image/png
Details
australis pinned tab glow overlapping the nav-bar's top border
(deleted), image/png
Details
fix everything but the tabs to not overflow,
(deleted), patch
MattN
: review-
MattN
: feedback+
Details | Diff | Splinter Review
It looks like fixing bug 908796 now has the tabstrip's arrows' borders overlapping the navbar slightly. Screenshot coming up shortly...
Blocks: 908796
No longer depends on: 908796
Keywords: regression
Attached image arrow-separator-overlap.png (deleted) —
Hardware: x86 → All
Summary: Tabstrip overflow arrow button borders overlap the navbar → Tabstrip overflow arrow button borders and separators overlap the navbar
The pinned tab title change glow also overlaps the nav-bar's top border. Bumping priority since the average user would likely notice the separator issue.
Whiteboard: [Australis:M?][Australis:P4] → [Australis:M?][Australis:P3]
(In reply to Matthew N. [:MattN] from comment #2) > The pinned tab title change glow also overlaps the nav-bar's top border. > Bumping priority since the average user would likely notice the separator > issue. Testcase: data:text/html;charset=utf-8,<link rel=icon href="http://mail.google.com/favicon.ico"><script>setInterval(function titleUp() { document.title = Date.now();}, 1500)</script>
Summary: Tabstrip overflow arrow button borders and separators overlap the navbar → Tabstrip overflow arrow button borders, pinned tab glow, and separators overlap the navbar
Ideally we should fix this before the merge.
Whiteboard: [Australis:M?][Australis:P3] → [Australis:M?][Australis:P2]
I feel bad about this patch, but it's the best I could come up with. Pulling up the entire pinned tab using margin-top makes it 'float' when selected, ie then there's a gap at the bottom. This was the best I could come up with. Giving the tab z-index: -1 made it unselectable. :-|
Attachment #831634 - Flags: review?
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Note that this patch also means the radial gradient is not 'shining through' the navbar top border as before. I don't see a way to avoid that.
Attachment #831634 - Flags: review? → review?(MattN+bmo)
Comment on attachment 831634 [details] [diff] [review] fix everything but the tabs to not overflow, Please fix XP as well. I'm fine with a workaround like this for now until we have bug 910987.
Attachment #831634 - Flags: review?(MattN+bmo)
Attachment #831634 - Flags: review-
Attachment #831634 - Flags: feedback+
The workaround in bug 908796 which caused this regression has been backed out, so this shouldn't be an issue anymore. Please re-open if this behaviour persists.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Whiteboard: [Australis:M?][Australis:P2] → [Australis:M-][Australis:P-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: