Closed
Bug 913597
Opened 11 years ago
Closed 11 years ago
Remove support for 'moz-webgl' context requests
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jgilbert, Assigned: emk)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
We still maintain support for retrieving a webgl context from a canvas via 'moz-webgl'. We should deprecate and then remove this.
Assignee: nobody → dglastonbury
Attachment #805984 -
Attachment is obsolete: true
Attachment #806004 -
Flags: review?(jgilbert)
Attachment #806004 -
Flags: review?(bjacob)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 806004 [details] [diff] [review]
fix-913597.patch
Review of attachment 806004 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome, thanks. bjacob can review if he wants, but it really only needs one of us.
Attachment #806004 -
Flags: review?(jgilbert)
Attachment #806004 -
Flags: review?(bjacob)
Attachment #806004 -
Flags: review+
Comment 4•11 years ago
|
||
Nope, that's fine :-)
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ae31c55333b3 - from the looks of it, we must only support experimental-webgl, and not webgl, on Android, but the test was running there, so https://tbpl.mozilla.org/php/getParsedLog.php?id=28010372&tree=Mozilla-Inbound
Comment 7•11 years ago
|
||
Oh, and b2g, which supports neither, https://tbpl.mozilla.org/php/getParsedLog.php?id=28013847&tree=Mozilla-Inbound
Reporter | ||
Comment 8•11 years ago
|
||
Yep, this is true.
Restrict the test to just 'moz-webgl' and 'experimental-webgl', since we already have a test that checks 'webgl'.
Reporter | ||
Comment 9•11 years ago
|
||
Actually, probably just test that if 'experimental-webgl' succeeds, then 'moz-webgl' fails.
Assignee | ||
Comment 11•11 years ago
|
||
Unbitrotted and removed the test for the unprefixed context name.
Assignee: nobody → VYV03354
Attachment #806004 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8362520 -
Flags: review?(jgilbert)
Reporter | ||
Updated•11 years ago
|
Attachment #8362520 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 12•11 years ago
|
||
Keywords: dev-doc-needed
Comment 13•11 years ago
|
||
Comment 14•11 years ago
|
||
Assignee | ||
Comment 15•11 years ago
|
||
Is WebGL totally unavailable on B2G?
Comment 16•11 years ago
|
||
WebGL is totally _available_ on B2G and even used in the Gallery application :-)
Assignee | ||
Comment 17•11 years ago
|
||
Then there should be a test preventing it from regression.
Blocks: 909903
Reporter | ||
Comment 18•11 years ago
|
||
(In reply to Benoit Jacob [:bjacob] from comment #16)
> WebGL is totally _available_ on B2G and even used in the Gallery application
> :-)
Yeah, but we have awful coverage on try. I don't remember if we successfully run any webgl on B2G at the moment.
Assignee | ||
Comment 19•11 years ago
|
||
According to bug 909903, WebGL context creation was possible until bug 900201 was fixed.
Assignee | ||
Comment 20•11 years ago
|
||
The workaround written in bug 900201 comment #19 did not work anymore.
https://tbpl.mozilla.org/?tree=Try&rev=7c9f1b59daca
We will have to disable the test on B2G atm.
Assignee | ||
Comment 21•11 years ago
|
||
Added SpecialPowers.pushPrevEnv to force-enable WebGL on B2G desktop build, and B2G check for exemption. (force-enable had no effect on B2G emulator.)
Try run: https://tbpl.mozilla.org/?tree=Try&rev=06babe90c8bc
Attachment #8362520 -
Attachment is obsolete: true
Attachment #8365627 -
Flags: review?(jgilbert)
Reporter | ||
Updated•11 years ago
|
Attachment #8365627 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 22•11 years ago
|
||
Comment 23•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 24•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•