Closed
Bug 914026
Opened 11 years ago
Closed 11 years ago
Crash resizing a detached-iframe (or closed) window
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla27
People
(Reporter: jruderman, Assigned: kanru)
References
Details
(Keywords: crash, regression, testcase)
Crash Data
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
khuey
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Regression from bug 891763.
+ if (mDocShell->GetIsBrowserOrApp()) {
With this testcase, mDocShell is null, so it crashes.
|
||
Updated•11 years ago
|
tracking-firefox26:
--- → ?
|
||
Updated•11 years ago
|
status-firefox25:
--- → unaffected
status-firefox26:
--- → affected
status-firefox27:
--- → affected
tracking-firefox27:
--- → +
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #810435 -
Flags: review?(khuey)
Comment on attachment 810435 [details] [diff] [review]
Check mDocShell before use
Review of attachment 810435 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #810435 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Comment 5•11 years ago
|
||
Thanks!
|
|
||
Comment 6•11 years ago
|
||
Verified fixed on Nightly 27.0a1 buildid 20131010030202.
|
|
||
Comment 7•11 years ago
|
||
Can we get an uplift nomination here to the beta channel with a risk/reward assessment?
Flags: needinfo?(kchen)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 810435 [details] [diff] [review]
Check mDocShell before use
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 891763
User impact if declined: browser crashes if the website tries to resize a detached iframe or closed window.
Testing completed (on m-c, etc.): already in firefox27
Risk to taking this patch (and alternatives if risky): little to none
String or IDL/UUID changes made by this patch: none
Attachment #810435 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(kchen)
|
|
||
Updated•11 years ago
|
Attachment #810435 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 9•11 years ago
|
||
|
|
||
Comment 10•11 years ago
|
||
status-b2g-v1.2:
--- → fixed
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•