Closed Bug 914195 Opened 11 years ago Closed 11 years ago

crash in moz_cairo_win32_surface_create_with_d3dsurface9

Categories

(Core :: Graphics, defect)

26 Branch
All
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: tracy, Assigned: jrmuizel)

References

Details

(Keywords: crash)

Crash Data

Attachments

(2 files, 1 obsolete file)

This bug was filed from the Socorro interface and is report bp-bc3d1740-f581-4e4d-a9bb-912bd2130909. =========================================================== Combined signatures put this at #14 Frame Module Signature Source 0 gkmedias.dll moz_cairo_win32_surface_create_with_d3dsurface9 gfx/cairo/cairo/src/cairo-win32-surface.c 1 xul.dll gfxWindowsSurface::gfxWindowsSurface(IDirect3DSurface9 *,unsigned int) gfx/thebes/gfxWindowsSurface.cpp 2 xul.dll mozilla::layers::OpaqueRenderer::Begin(mozilla::layers::LayerD3D9 *) gfx/layers/d3d9/ThebesLayerD3D9.cpp 3 xul.dll mozilla::layers::ThebesLayerD3D9::DrawRegion(nsIntRegion &,mozilla::layers::Layer::SurfaceMode,nsTArray<mozilla::layers::ReadbackProcessor::Update> const &) gfx/layers/d3d9/ThebesLayerD3D9.cpp 4 d3d9.dll SSEFloat16Conversion8
Depends on: 907544
Do you have steps?
Attached file crash stats correlations (deleted) —
I don't have steps, just getting this on file to begin investigations, as it it nearing topcrash status.
Keywords: steps-wanted
Ok, this is coming from bug 907544 so we can back it out if we can't find the cause, but lets give it a bit of time to find steps.
Attached patch Do the needful (obsolete) (deleted) — Splinter Review
Attachment #803772 - Flags: review?(bgirard)
Comment on attachment 803772 [details] [diff] [review] Do the needful Review of attachment 803772 [details] [diff] [review]: ----------------------------------------------------------------- This is an improvement but we're still changing the behavior. If GetDC returns null previously we would return a null gfxWindowSurface in OpaqueRenderer::Begin() but now we will return an error surface: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=907544&attachment=799756 So we might change the crash to an empty rendering. Perhaps we should restore get GetDC failures yield an empty surface from OpaqueRenderer::Begin().
Attachment #803772 - Flags: review?(bgirard)
Comment on attachment 803772 [details] [diff] [review] Do the needful Per discussion, close but not quite.
Attachment #803772 - Flags: review-
Attached patch Be more careful (deleted) — Splinter Review
Attachment #803772 - Attachment is obsolete: true
Attachment #803802 - Flags: review?(bgirard)
Attachment #803802 - Flags: review?(bgirard) → review+
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Issue is resolved - clearing old keywords - qa-wanted clean-up
Keywords: steps-wanted
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: