Closed
Bug 914195
Opened 11 years ago
Closed 11 years ago
crash in moz_cairo_win32_surface_create_with_d3dsurface9
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: tracy, Assigned: jrmuizel)
References
Details
(Keywords: crash)
Crash Data
Attachments
(2 files, 1 obsolete file)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-bc3d1740-f581-4e4d-a9bb-912bd2130909.
===========================================================
Combined signatures put this at #14
Frame Module Signature Source
0 gkmedias.dll moz_cairo_win32_surface_create_with_d3dsurface9 gfx/cairo/cairo/src/cairo-win32-surface.c
1 xul.dll gfxWindowsSurface::gfxWindowsSurface(IDirect3DSurface9 *,unsigned int) gfx/thebes/gfxWindowsSurface.cpp
2 xul.dll mozilla::layers::OpaqueRenderer::Begin(mozilla::layers::LayerD3D9 *) gfx/layers/d3d9/ThebesLayerD3D9.cpp
3 xul.dll mozilla::layers::ThebesLayerD3D9::DrawRegion(nsIntRegion &,mozilla::layers::Layer::SurfaceMode,nsTArray<mozilla::layers::ReadbackProcessor::Update> const &) gfx/layers/d3d9/ThebesLayerD3D9.cpp
4 d3d9.dll SSEFloat16Conversion8
Comment 1•11 years ago
|
||
Do you have steps?
Reporter | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
I don't have steps, just getting this on file to begin investigations, as it it nearing topcrash status.
Keywords: steps-wanted
Comment 4•11 years ago
|
||
Ok, this is coming from bug 907544 so we can back it out if we can't find the cause, but lets give it a bit of time to find steps.
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #803772 -
Flags: review?(bgirard)
Comment 6•11 years ago
|
||
Comment on attachment 803772 [details] [diff] [review]
Do the needful
Review of attachment 803772 [details] [diff] [review]:
-----------------------------------------------------------------
This is an improvement but we're still changing the behavior. If GetDC returns null previously we would return a null gfxWindowSurface in OpaqueRenderer::Begin() but now we will return an error surface:
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=907544&attachment=799756
So we might change the crash to an empty rendering. Perhaps we should restore get GetDC failures yield an empty surface from OpaqueRenderer::Begin().
Attachment #803772 -
Flags: review?(bgirard)
Comment 7•11 years ago
|
||
Comment on attachment 803772 [details] [diff] [review]
Do the needful
Per discussion, close but not quite.
Attachment #803772 -
Flags: review-
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #803772 -
Attachment is obsolete: true
Attachment #803802 -
Flags: review?(bgirard)
Updated•11 years ago
|
Attachment #803802 -
Flags: review?(bgirard) → review+
Comment 9•11 years ago
|
||
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment 10•10 years ago
|
||
Issue is resolved - clearing old keywords - qa-wanted clean-up
Keywords: steps-wanted
You need to log in
before you can comment on or make changes to this bug.
Description
•