Open Bug 914247 Opened 11 years ago Updated 2 years ago

Move the remaining EXTRA_COMPONENTS to moz.build

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(Not tracked)

People

(Reporter: Ms2ger, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #870370 +++ ./netwerk/test/httpserver/Makefile.in:EXTRA_COMPONENTS += \ ./layout/tools/reftest/Makefile.in:EXTRA_COMPONENTS += reftest-cmdline.manifest still need to move to moz.build. Those are dependent on XPI_NAME. XPI_NAME is a variable set like $(MAKE) libs XPI_NAME=... and is thus not available in moz.build files. I think ted was going to look at these.
Flags: needinfo?(ted)
This should be landed as soon as these two assignments have disappeared.
I don't recall saying that, I just recall saying that I knew why those were there: to get an XPI-packaged version of reftest (which requires httpd.js) for use in running reftest against packaged builds. If we can accomplish that same goal differently that's fine. I believe the biggest reason was preserving dbaron's use case of running firefox -reftest directly. If he's still using that then we'll have to figure out some clever way of XPI packaging.
Flags: needinfo?(ted)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > I don't recall saying that, I just recall saying that I knew why those were > there: to get an XPI-packaged version of reftest (which requires httpd.js) > for use in running reftest against packaged builds. If we can accomplish > that same goal differently that's fine. I believe the biggest reason was > preserving dbaron's use case of running firefox -reftest directly. If he's > still using that then we'll have to figure out some clever way of XPI > packaging. He mentioned in bug 859339 that he was still doing that, so...
Summary: Remove the remaining EXTRA_COMPONENTS to moz.build → Move the remaining EXTRA_COMPONENTS to moz.build
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: