When connecting to keon, the device doesn't come out of sleep when the permission dialog is show. I must press the power button to wake it up and confirm the connection. I think we want the device to come out of sleep when prompting the user to all the connection. My build is: Gecko -- commit 7dc9265ed90037fbd273a05d322637931191d87a Gaia -- commit 43cf923c3020d77a9fa962cc0c30fd27f647660d

The device is not locked. Screen is off (brightness).

Comment on attachment 810558 [details] [diff] [review] Patch v1 Review of attachment 810558 [details] [diff] [review]: ----------------------------------------------------------------- That looks very bad for multiple reasons. Calling an internal gaia event is wrong, we should only rely on chrome event, ideally sent from shell.js in order to keep track of all possible events gecko can throw to gaia. Also I don't feel confident about patching main.js to add such b2g specific thing. I'd rather have added something in shell.js around here: http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#1008 This method is called when we display the prompt asking to allow the connection. So it won't turn on the screen if we have the pref that bypass the prompt. But we could also turn the screen on when a new connection is accepted: http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#1054 Actually, it may be even better to just let gaia turn the screen on from here: https://mxr.mozilla.org/gaia/source/apps/system/js/remote_debugger.js#18 ScrenManager.turnScreenOn();

Who can review that? Do I need to do a pull request?

Comment on attachment 811528 [details] [diff] [review] Patch V2 Review of attachment 811528 [details] [diff] [review]: ----------------------------------------------------------------- Passby r+

Can someone land this patch? And how can we get that in Firefox OS 1.2?

(In reply to Paul Rouget [:paul] from comment #6) > Can someone land this patch? And how can we get that in Firefox OS 1.2? Could you send a pull request? You need approval to go 1.2, but I don't know who to ask for. https://wiki.mozilla.org/Release_Management/B2G_Landing

Comment on attachment 811528 [details] [diff] [review] Patch V2 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): new feature (App Manager) [User impact] if declined: people might miss the prompt screen [Testing completed]: locally [Risk to taking this patch] (and alternatives if risky): low [String changes made]: none

Pull request: https://github.com/mozilla-b2g/gaia/pull/12525 What next?

Travis build on pull request is green, merged to gaia master: https://github.com/mozilla-b2g/gaia/commit/e519499e33a92b8ccb757492b9ff59d174cf23b3 from pull request: https://github.com/mozilla-b2g/gaia/pull/12525

Comment on attachment 811528 [details] [diff] [review] Patch V2 Low risk, improves user experience.

Thanks. How do I land that?

How do we land this patch in Gaia 1.2?

(In reply to Paul Rouget [:paul] from comment #13) > How do we land this patch in Gaia 1.2? Sheriffs will do the uplift for you.

I believe they will only uplift for 1.2 if koi+ is set, so asking koi? See comment #8 for justification: https://bugzilla.mozilla.org/show_bug.cgi?id=914557#c8

(In reply to James Burke [:jrburke] from comment #15) > I believe they will only uplift for 1.2 if koi+ is set, so asking koi? See > comment #8 for justification: > https://bugzilla.mozilla.org/show_bug.cgi?id=914557#c8 The patch already has approval-gaia-v1.2+ so koi+ is not needed.

Uplifted e519499e33a92b8ccb757492b9ff59d174cf23b3 to: v1.2: cc0dafb571abd3275d9b64b3e91c3f26262ccdba

Uplifted e519499e33a92b8ccb757492b9ff59d174cf23b3 to: v1.3 already had this commit