Martin Stránský [:stransky] (ni? me) Assignee
	Description • 11 years ago

Let's remove MOZ_WIDGET_GTK2 and use MOZ_WIDGET_GTK everywhere. It helps to write the plugin code for gtk2/gtk3 toolkits.

	Karl Tomlinson (:karlt)
	Comment 2 • 11 years ago

Comment on attachment 805958 [details] [diff] [review]
patch

>+#if !(MOZ_WIDGET_GTK == 2)

(MOZ_WIDGET_GTK != 2) or (MOZ_WIDGET_GTK > 2) please.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 11 years ago

Thanks!

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 4 • 11 years ago

Tyr build: https://tbpl.mozilla.org/?tree=Try&rev=7e8a2bdca1e7

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 11 years ago

Comment on attachment 806488 [details] [diff] [review]
patch for check in

For single patch bugs, please just use the checkin-needed keyword :)

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/98271bb483eb

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

This was backed out for crashtest-ipc and reftest-ipc failures, along with Linux mochitest-1 and reftest failures. Please rebase this patch and run it through Try again (linux32+64 opt+debug). If it's still green, it's probably a needs-clobber situation. In that case, please add a note to the CLOBBER file so that the build machines clobber first. Sorry for the hassle.

https://tbpl.mozilla.org/php/getParsedLog.php?id=28095796&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=28099533&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=28099217&tree=Mozilla-Inbound

	Karl Tomlinson (:karlt)
	Comment 8 • 11 years ago

Martin, can you remove the DownloadPlatform.cpp changes here, please because bug 884708 has the appropriate solution there.  That will have to land first.

I'm guessing the failures are for new instances of MOZ_WIDGET_GTK2 somewhere, which is why we need to remove this variable.  This kind of change shouldn't need a clobber.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 9 • 11 years ago

Thanks. This patch does not touch configure.in nor DownloadPlatform.cpp so it sould be safe to apply it. 

We can do the configure.in change later when all parts are done.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 10 • 11 years ago

Fixed a typo.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 11 • 11 years ago

Comment on attachment 807656 [details] [diff] [review]
patch, v3

Try for this patch: https://tbpl.mozilla.org/?tree=Try&rev=9a2d7be2480f

	Philip Chee
	Comment 12 • 11 years ago

Are you going to fix comm-central too?

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 13 • 11 years ago

(In reply to Philip Chee from comment #12)
> Are you going to fix comm-central too?

Ahh, good point. I'll add it to my todo-list.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 14 • 11 years ago

Looks like .js preprocessor doesn't like brackets. 
Fixed and pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2e6cc43acec5

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 15 • 11 years ago

Comment on attachment 808503 [details] [diff] [review]
patch, v4

Please land this patch before Bug 917270.

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 11 years ago

https://hg.mozilla.org/integration/fx-team/rev/7af33dde6db7

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/7af33dde6db7