Gaia: 2d870100a945272824f8e42a8c52aac095fe907e B-D 2013-09-11 04:59:20 Gecko: 46c335b301fdb32f47e58c665190ffc41522ae00 BuildID 20130911062051 Version 26.0a1 * Symptom: 1. The switch call screen icon is incomplete. * Reproduce Steps 1. Make a call to other device or MT call to DUT. 2. MT a second call to DUT. 3. Check the switch call screen icon. * Actual results: 1. The switch call screen icon is incomplete. * Expected results: 1. The switch call screen icon should be complete and follow the spec definition.

Is this an HiDPI device you're testing on? On my side it looks different...

Hi Gabriele, Our reference phone for wasabi build has 4.3" qHD 960x540 display, thanks.

(In reply to Enpei from comment #3) > Our reference phone for wasabi build has 4.3" qHD 960x540 display, thanks. Good, I'll retest the layout using that size and fix it accordingly; I must have gotten some of the relative measures wrong in my CSS.

I can't seem to reproduce this issue in my browser so I assume it's caused by the screen DPI difference, I think I will need a properly scaled icon in order to fix it.

I've attached a patch with manually scaled icons for 1.5x and 2x scenarios; Enpei could you test it and see if the problems goes away? I've tried reproducing it on the desktop client adjusting the DPIs and screen resolution but to no avail. Enpei could you try it with this patch applied? If it works correctly then we'll have to ask for proper icons to be made.

according to 9/25 triage result, change to koi+

Gabriele, I think you are fixing this bug now. Assign this bug to you.

(In reply to Ken Chang from comment #10) > Gabriele, I think you are fixing this bug now. Assign this bug to you. Yes, I'll be working on it this week.

Hi Gabriele, I tried on following wasabi build with the patch yet still see "Switch ca...". I hope I install patch correctly, any way I can assure that? Gaia: ccefcfd95697896b27d12824cce51b0a7af4518e Gecko: 85ead3614a3de104ca8b52c63a5b9b35c68feaa5 BuildID 20130925141755 Version 26.0a2

Hi Enpei, > I tried on following wasabi build with the patch yet still see "Switch > ca...". I hope I install patch correctly, any way I can assure that? does the gap below the icon on the right still shows? I'm unsure about the "Switch ca..." part as I followed the spec for the font-size. Maybe I'll have to pick a smaller one. I will try to run this in the emulator in the hope of reproducing the same screen size / DPI but if I can't then somebody from Taipei will need to pick it up.

(In reply to Gabriele Svelto [:gsvelto] from comment #13) > does the gap below the icon on the right still shows? Yes. > I'm unsure about the "Switch ca..." part as I followed the spec for the font-size. Maybe I'll > have to pick a smaller one. I will try to run this in the emulator in the > hope of reproducing the same screen size / DPI but if I can't then somebody > from Taipei will need to pick it up. For "Switch ca..." part, as you can see in attached screen shot, the wording is "Switch Ca..", but it should display the complete words "Switch Call" as specified in spec.

Quick update, I've successfully hacked the emulator adding a profile with the same resolution and DPI as the wasabi. I'll try and reproduce the issue there and open a separate bug to merge my changes so that whoever needs emulating it will have the settings ready.

This is a one-line CSS change to make the "Switch calls" text properly visible on all devices. I could not reproduce the issue in attachment 802917 [details] where a small gap is visible below the icon; I imagine this might have been caused by something else that's now fixed. I used my Geeksphone Peak to test as it has the same resolution & DPI; I'll attach a screenshot shortly with the final result.

Here's how the call waiting looks like on my device after applying this patch.

Comment on attachment 815863 [details] [diff] [review] [PATCH 1/2] Adjust the text size to make it entirely visible Review of attachment 815863 [details] [diff] [review]: ----------------------------------------------------------------- That should do it :)

I've accidentally push this to master from my branch instead of merging the pull request, hope this isn't a problem. Anyway pushed to gaia/master 56cef91764416b180907035fa11f0fd95dc9eb2b.

Uplifted 56cef91764416b180907035fa11f0fd95dc9eb2b to: v1.2: debb5beeab7ac413168793f6e595adf74f77b489

Verified on wasabi 1015 build, still has the problem, I will double check again tomorrow before reopening the bug. Gaia: 94e3088c56c7348655ae76613defd126426cc722 Gecko: 292baf182d8778772335fd2f6fa84eb82e31b906 BuildID 20131015101245 Version 26.0a2

(In reply to Enpei from comment #21) > Verified on wasabi 1015 build, still has the problem, I will double check > again tomorrow before reopening the bug. OK, if the problem is still there then somebody with access to a wasabi device must look into this. Or I must get one as no matter what I tried (devices with the same resolution, emulator, etc...) I can't reproduce that glitch.

Scratch what I just said, I've managed to reproduce it now! I'll re-open this bug and prepare a second patch to fix the other problem besides the text (the gap forming below the switch button).

This is a pure CSS changes that adjusts all elements of a call so that the total height is always 8rem as per the original spec in bug 829104. This actually fixes two issues: - When in CDMA call waiting mode the total height of the call info are was 7.7rem and the call switch button area 7.5rem creating the gap visible in attachment 802917 [details]. Both heights should have been 8rem as per the original design - When in regular mode the call height would be 8rem if no additional contact info was available but only 7.7rem when it was This patch fixes both issues by ensuring that the call height is always 8rem, this also significantly simplifies the CDMA-specific CSS code.

Comment on attachment 815863 [details] [diff] [review] [PATCH 1/2] Adjust the text size to make it entirely visible Renaming this attachment to highlight that it solved only part of the problem.

Woops, the bug number in the original patch comment was wrong.

Comment on attachment 817140 [details] [diff] [review] [PATCH 2/2] Make the height of the call elements uniform Review of attachment 817140 [details] [diff] [review]: ----------------------------------------------------------------- all good, let's land!

Thanks for the review! Landed on master e98b6535de460ad7cf0f2befc18556cdc67940e4 and v1.2 56124ca800e1ee21b8fb35765472f3b53bdaf0c6 Now this should be fixed for good :-)

Hi Gabriele, Please check my latest screen shot, it still only shows "Switch ca..", not "Switch call". Would you mind if I reopen the bug? But no gap is found now. Wasabi Gaia: 922de46ad5e4a8b513b24233a7f3bc54b93e9612 Gecko: f28b860ef7a9fb9e0960b2aabaee55a42d17633b BuildID 20131018170959 Version 26.0a2

(In reply to Enpei from comment #30) > Please check my latest screen shot, it still only shows "Switch ca..", not > "Switch call". Would you mind if I reopen the bug? But no gap is found now. This is weird but you do have the correct Gaia version so the problem should be gone :-/ Could you open a follow-up specifically for this instead of re-opening this bug? I'll try to reproduce it myself.

Sure, bug 928597 is created.