Closed
Bug 9153
Opened 25 years ago
Closed 25 years ago
PinSelectionInPRE() breaks Ender TextFields/TextAreas
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
M9
People
(Reporter: kinmoz, Assigned: mozeditor)
References
Details
The PinSelectionInPRE() checkin to nsTextEditRules.cpp revision 1.32 breaks
ender TextFields and TextAreas because it finds no pre tag.
To reproduce this bug:
1. Launch viewer.
2. Select "Style->Widget Rendering Mode Pref->Gfx" from the menus.
3. Select "File->Samples->demo #8" from the menus.
You should now see a whole bunch of text fields and text areas. Each one is an
Ender. Notice how you can type but nothing shows up?
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: M8
Assignee | ||
Comment 1•25 years ago
|
||
fixed
Reopening bug, since it still doesn't work on Win32.
Joe, I pulled your changes, but I still can't type into ender textareas and
textfields. The TEXT_EDITOR_FLAG_PLAINTEXT flag is set for ender textareas and
textfields, so it still tries to pin the selection.
updating severity to Blocker since 9139 is a blocker and is resolved as a
duplicate of this
Assignee | ||
Updated•25 years ago
|
Assignee: jfrancis → buster
Status: REOPENED → NEW
Target Milestone: M8 → M9
Assignee | ||
Comment 6•25 years ago
|
||
I've been way too confused about too many things to do this correctly. The most
recent example was thinking that ender was already the default text widget, which
it isn't.
I'm disabling the selection pinning for now. Ender widgets will work again but
plaintext mail compose will still be broken.
I do not know the answer to the following question: exactly which uses of ender
will be plaintext AND demand a PRE tag around all the content? How do I identify
these uses? Once that is answered I can hook up the existing code to prevent
edit actions from taking place outside that PRE tag.
I will not be able to address this in m8. Assigning to Steve. Steve, I
recommend either reassinging this if it is a must for m8, or giving it back to me
with a later milestone.
assigned back to Joe, M9, resolution cleared. Joe, we can work this out via
email.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•25 years ago
|
||
accepting bug. we have agreed that all nsTextEditor usages will require a PRE
tag that holds all content, so fixing this bug now means:
1) turning back on the work I already did
2) forcing an enclosing PRE tag at editor init time
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•25 years ago
|
||
well, i unilaterally changed my mind about what we really want to do here. I now
believe we don't want a PRE tag, so that users of plaintext ender widgets can set
font and do other things that make make sense for mail quoting, or spell checking
feedbvack, or whatever. So I'm forcing a "white-space: pre" style attribute on
the body tag whenever a plaintext editor is invoked.
I note that there are still problems typing into some of the text widgets, but i
dont think the remaining problems have to do with the issues addressed in this
bug.
Comment 10•25 years ago
|
||
verified in 7/26 build...I can type now in the textarea and fields.
You need to log in
before you can comment on or make changes to this bug.
Description
•