Closed
Bug 915642
Opened 11 years ago
Closed 11 years ago
Allow simple variable references in includedeps files
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
I'm going to need this in bug 907365 (not really directly, but its future-proofing is requiring it).
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #803662 -
Flags: review?(gps)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 803662 [details] [diff] [review]
Allow simple variable references in includedeps files
Review of attachment 803662 [details] [diff] [review]:
-----------------------------------------------------------------
I wonder at what point includedeps will have reinvented include :)
::: build/pymake/pymake/parser.py
@@ +409,5 @@
> + expansion.appendfunc(functions.VariableRef(None,
> + data.StringExpansion(element, None)))
> + elif element:
> + expansion.appendstr(element)
> + i += 1
Nit: Use enumerate() instead of tracking i explicitly.
Attachment #803662 -
Flags: review?(gps) → review+
|
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/5d83a8746631
https://hg.mozilla.org/integration/mozilla-inbound/rev/b86d7ce8d1eb
Status: NEW → ASSIGNED
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•