Closed
Bug 915740
Opened 11 years ago
Closed 11 years ago
Integrate adb helper addon into the app manager (UI part)
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(3 files)
|
(deleted),
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 2•11 years ago
|
||
BOOM! This feels so great :)
Attachment #804421 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 3•11 years ago
|
||
As soon as the addon is installed or uninstalled, the connection footer is updated. The list of devices is also updated live.
Comment on attachment 804421 [details] [diff] [review]
Patch v1
Review of attachment 804421 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/locales/en-US/chrome/browser/devtools/app-manager.dtd
@@ +25,5 @@
> <!ENTITY connection.disconnect "Disconnect">
> <!ENTITY connection.showDeviceCtrlCenter "Click for More Details">
> +<!ENTITY connection.notConnected2 "Not Connected.">
> +<!ENTITY connection.connectTo "Connect to:">
> +<!ENTITY connection.noDeviceFound "No device found. Plug a device">
"Plug in a device." sounds more natural.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #804557 -
Flags: review?
|
||
Comment 6•11 years ago
|
||
Comment on attachment 804421 [details] [diff] [review]
Patch v1
Review of attachment 804421 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, works perfectly!
(I haven't been able to test multiple devices as I only have one data usb cable :/)
Attachment #804421 -
Flags: review?(poirot.alex) → review+
|
|
||
Updated•11 years ago
|
Attachment #804557 -
Flags: review? → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Comment 7•11 years ago
|
||
This needs a rebase.
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
|
Assignee | |
Comment 9•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•