Closed Bug 915909 Opened 11 years ago Closed 11 years ago

SeaMonkey should make use of exif orientation when displaying attached images

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #877520 +++ Backend support for interpreting EXIF orientation information in JPEG images was introduced with bug 825771 by implementing the CSS3 "image-orientation" property. This works already in the browser for stand-alone images in top-level documents per bug 298619. Images attached to e-mail and news messages still ignore the EXIF orientation information. Thunderbird added "from-image" rules in bug 877520 for their themes, this bug aims to apply those rules to SM classic and modern themes.
Attached patch Proposed patch (obsolete) (deleted) — Splinter Review
Straight-forward fix following bug 877520 attachment 797739 [details] [diff] [review]. Tested on Windows 7 with both default and classic themes using attachment 755730 [details] added to a message. The image is correctly displayed in portrait orientation in accordance with its EXIF information.
Attachment #804152 - Flags: review?(neil)
I have these in my messageBody.css notes: TB Bug 747415 - Make our css more efficient TB Bug 877520 - Thunderbird should make use of exif orientation when displaying attached images. Core Bug 879131 - Use prefix-less zoom-in and zoom-out CSS property values. I think 747415 and 879131 are small enough not to warrant separate bugs.
Attachment #804152 - Flags: review?(neil) → review+
(In reply to Philip Chee from comment #2) > I think 747415 and 879131 are small enough not to warrant separate bugs. 879131 - just about, since the affected lines are already in the patch context. 747415 - have you seen how big their patch is?
Attached patch Proposed patch (v2) (deleted) — Splinter Review
(In reply to neil@parkwaycc.co.uk from comment #3) > 879131 - just about, since the affected lines are already in the patch context. Agreed, that's easy enough to address here and those are the only instances. > 747415 - have you seen how big their patch is? I'll happily skip this for another patch. ;-)
Attachment #804152 - Attachment is obsolete: true
Attachment #804451 - Flags: review?(neil)
Attachment #804451 - Flags: review?(neil) → review+
Thanks Neil, push for comm-central please.
Keywords: checkin-needed
FTR: Thunderbird covered the removal of "-moz-" for zoom-* in bug 916085.
> 747415 - have you seen how big their patch is? Just the messageBody.css changes :P
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
No longer blocks: TB2SM
Target Milestone: --- → seamonkey2.23
(In reply to Philip Chee from comment #7) > > 747415 - have you seen how big their patch is? > Just the messageBody.css changes :P Ok, that would have narrowed the patch over there down significantly. Nevertheless, those changes didn't quite fit into the scope of this bug, thus maybe clone that TB bug to SM to take care of any CSS cleanup that has suite/themes counterparts as well.
> thus maybe clone that TB bug to SM to take care of any CSS cleanup that has > suite/themes counterparts as well. I filed bug 916478.
Blocks: 939540
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: