Closed
Bug 915944
Opened 11 years ago
Closed 11 years ago
Don't use TEXTURE_DEALLOCATE_HOST with canvases and deprecated texture clients
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla26
| Tracking | Status | |
|---|---|---|
| firefox24 | --- | unaffected |
| firefox25 | + | fixed |
| firefox26 | + | fixed |
People
(Reporter: nrc, Assigned: nrc)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
mattwoodrow
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Or we leak all over the place.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #804139 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Attachment #804139 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 804139 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 900133
User impact if declined: we will leak the texture backing every canvas we create on Android and Windows OMTC (the latter is not yet a supported platform).
Testing completed (on m-c, etc.): I can leave this for a few days on m-c, but I would like to get it on Aurora before the uplift.
Risk to taking this patch (and alternatives if risky): Low risk - restoring previous behaviour. No alternatives.
String or IDL/UUID changes made by this patch: None
Attachment #804139 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Attachment #804139 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 5•11 years ago
|
||
Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•