Closed
Bug 915986
Opened 11 years ago
Closed 11 years ago
B2G RIL: check pin2 is null when updating FDN
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2 FC (16sep)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(2 files)
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
When calling icc.updateContact("fdn", contact) without pin2 provided,
I found that if the pin2 is null, the modem won't check pin2 even when we're trying to modify a fdn contact.
But if we provide some data for pin2, then modem will try to check the pin2 is correct or not.
So RIL part should check whether pin2 is null first.
Assignee | ||
Comment 1•11 years ago
|
||
Need only 1 reviewer here.
Attachment #804252 -
Flags: review?(vyang)
Attachment #804252 -
Flags: review?(htsai)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #804253 -
Flags: review?(vyang)
Attachment #804253 -
Flags: review?(htsai)
Updated•11 years ago
|
Attachment #804252 -
Flags: review?(vyang)
Attachment #804252 -
Flags: review?(htsai)
Attachment #804252 -
Flags: review+
Comment 3•11 years ago
|
||
Comment on attachment 804253 [details] [diff] [review]
Part 2: test case for pin2 is null.
Review of attachment 804253 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you :)
Attachment #804253 -
Flags: review?(vyang)
Attachment #804253 -
Flags: review?(htsai)
Attachment #804253 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aa19c3362c67
https://hg.mozilla.org/mozilla-central/rev/dd6495277f48
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•