Closed Bug 915986 Opened 11 years ago Closed 11 years ago

B2G RIL: check pin2 is null when updating FDN

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.2 FC (16sep)

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(2 files)

When calling icc.updateContact("fdn", contact) without pin2 provided, I found that if the pin2 is null, the modem won't check pin2 even when we're trying to modify a fdn contact. But if we provide some data for pin2, then modem will try to check the pin2 is correct or not. So RIL part should check whether pin2 is null first.
Attached patch Part 1: Check pin2 in RIL (deleted) — Splinter Review
Need only 1 reviewer here.
Attachment #804252 - Flags: review?(vyang)
Attachment #804252 - Flags: review?(htsai)
Attachment #804253 - Flags: review?(vyang)
Attachment #804253 - Flags: review?(htsai)
Attachment #804252 - Flags: review?(vyang)
Attachment #804252 - Flags: review?(htsai)
Attachment #804252 - Flags: review+
Comment on attachment 804253 [details] [diff] [review] Part 2: test case for pin2 is null. Review of attachment 804253 [details] [diff] [review]: ----------------------------------------------------------------- Thank you :)
Attachment #804253 - Flags: review?(vyang)
Attachment #804253 - Flags: review?(htsai)
Attachment #804253 - Flags: review+
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
Blocks: 935399
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: