Closed
Bug 916147
Opened 11 years ago
Closed 11 years ago
jit-tests should output the test filepath relative to topsrcdir, not the absolute path
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: emorley, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
dminor
:
review+
|
Details | Diff | Splinter Review |
When filing intermittent failure bugs for jit-tests (of which there have been many of late), each time I have to hand-trim the full filepath, so the summary isn't bloated.
ie from the log:
{
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --baseline-eager --no-ti --no-fpu
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion --no-ti
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js |
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --ion-eager
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --ion-eager --ion-check-range-analysis
FAIL - e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --baseline-eager: e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js:4:6 TypeError: can't convert this to string
}
Ideally the path relative to topsrcdir would be used instead, eg:
{
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --baseline-eager --no-ti --no-fpu
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion --no-ti
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js |
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js | --ion-eager
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js | --ion-eager --ion-check-range-analysis
FAIL - js\src\jit-test\tests\baseline\bug846072.js
TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\baseline\bug846072.js | --baseline-eager: js\src\jit-test\tests\baseline\bug846072.js:4:6 TypeError: can't convert this to string
}
Assignee | ||
Comment 1•11 years ago
|
||
This makes the suggested change and, since we're already touching the tinderbox output, adds complete stdout, stderr, exit-code, and timeout status dumps on failure. Seems to work locally.
Comment 2•11 years ago
|
||
Comment on attachment 804547 [details] [diff] [review]
fix_up_jittest_tinderbox_output-v0.diff
Review of attachment 804547 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and runs fine locally on my pandaboard.
Attachment #804547 -
Flags: review?(dminor) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Ran it by try, just in case. All green:
https://tbpl.mozilla.org/?tree=Try&rev=e82de138ae5b
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bd5b8cc216e
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Reporter | ||
Comment 5•11 years ago
|
||
Thank you for doing this Terrence! :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•