Closed
Bug 916166
Opened 11 years ago
Closed 11 years ago
[app manager] Disable the network monitor
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(firefox26 verified, firefox27 verified)
VERIFIED
FIXED
Firefox 27
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ochameau
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It doesn't work.
Comment 1•11 years ago
|
||
Neither the Network logging the Console. Should we disable that as well? How hard would it be to fix this? Mihai?
Flags: needinfo?(mihai.sucan)
Comment 2•11 years ago
|
||
I talked to Paul in Paris about the problems with network logging.
1. network requests happen in the main process, not in content processes where the content actors work (including the console actor). So, we don't see any requests.
2. network requests in the main process have no associatedWindow property. The global console actor will show all network requests, from the entire system, without being able to filter them based on windows or apps.
We need a solution to have the toolbox connect to the global console actor and get the network requests for the app that the toolbox is attached to. Or we needed the content console actor to talk to the main process to get the network requests associated to the content process. ( i prefer the latter approach )
This needs platform work. Do we have an open bug for finding a solution?
Flags: needinfo?(mihai.sucan)
Assignee | ||
Comment 3•11 years ago
|
||
See bug 917227 for solving the Network monitor problem. In the meantime, we need to disable it.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [needed-in-aurora-26]
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Comment on attachment 806001 [details] [diff] [review]
Patch v1
Review of attachment 806001 [details] [diff] [review]:
-----------------------------------------------------------------
No more network panel on remote apps, still one on local tabs, looks good!
Attachment #806001 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 806001 [details] [diff] [review]
Patch v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: useless tool available to the user
Testing completed (on m-c, etc.): fx-team, m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no
Attachment #806001 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #806001 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•11 years ago
|
||
Comment 10•11 years ago
|
||
Verified as fixed on:
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 - Network Monitor and Scratchpad disabled.
Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0 - Network Monitor disabled.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment 11•11 years ago
|
||
Also verified on Mac OS X 10.8.4 and Windows 7 64bit on the same versions (except for Aurora on Windows - I couldn't get connected to the Simulator there no matter what I did).
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•