Closed Bug 916205 Opened 11 years ago Closed 11 years ago

Create and enable dynamic UA override list in B2G

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(2 files, 1 obsolete file)

Remove UA override list from Gaia: https://github.com/mozilla-b2g/gaia/pull/12226
(deleted), text/html
fabrice
: review+
Details
Add and package UA override list (v2)
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
The dynamic UA override list is in JSON format. We need to convert the old override prefs to JSON and check it into Gaia. This way, the list ships with Gaia and the file on the server can track the file in the Gaia repo.
Attached patch Add and package UA override list (v1) (obsolete) (deleted) — — Splinter Review
This patch includes a new UA override list converted from the current list in Gaia. The reason it's moved to Gecko is because we want to ship the file in the Gecko package. The patch also includes the prefs to turn on the new UA override system, which will use the new list. I verified it to work on a B2G build on my Unagi device.
Attachment #804822 - Flags: review?(fabrice)
When the above Gecko patch lands, the old list in Gaia can be safely deleted.
Attachment #804823 - Flags: review?(fabrice)
Attachment #804822 - Flags: review?(fabrice) → review+
Comment on attachment 804822 [details] [diff] [review] Add and package UA override list (v1) Asking review on the Makefile bits
Attachment #804822 - Flags: review?(mh+mozilla)
Attachment #804823 - Flags: review?(fabrice) → review+
Comment on attachment 804822 [details] [diff] [review] Add and package UA override list (v1) Review of attachment 804822 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/app/Makefile.in @@ +96,5 @@ > + # strip out comment lines, which are not valid in JSON > + sed -e "/^ *\\/\\//d" -e "/^ *$$/d" $^ > $@ > + > +libs:: $(UA_UPDATE_FILE) > + $(INSTALL) $(IFLAGS1) $^ $(FINAL_TARGET) Use INSTALL_TARGETS (see config/rules.mk)
Attachment #804822 - Flags: review?(mh+mozilla) → review-
I think this is right. Carrying over fabrice's r+ and re-asking review on Makefile bits
Attachment #805806 - Flags: review?(mh+mozilla)
Attachment #804822 - Attachment is obsolete: true
Attachment #805806 - Flags: review?(mh+mozilla) → review+
Checked into https://hg.mozilla.org/integration/b2g-inbound/rev/82d40fae202d Also noming for koi because we want dynamically updatable UA override list to work for 1.2
blocking-b2g: --- → koi?
blocking-b2g: koi? → koi+
https://hg.mozilla.org/mozilla-central/rev/82d40fae202d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
The Gaia pull request still needs to be merged into master and 1.2 branch
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
Master: https://github.com/mozilla-b2g/gaia/commit/18bd102d833e858e97d60db5c05607e172a10859 Will leave it to jhford to do the uplift.
status-b2g-v1.2: fixed → affected
Flags: needinfo?(jhford)
Keywords: checkin-needed
[v1.2 51f3c79] Merge pull request #12226 from darchons/bug916205-create-and-enable-dynamic-ua
status-b2g-v1.2: affected → fixed
Flags: needinfo?(jhford)
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: QARegressExclude
Depends on: 1024588
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: