Closed
Bug 916433
Opened 11 years ago
Closed 11 years ago
The task in the "tail.js" file of the Downloads API tests is not executed
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: Paolo, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Felipe
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The task in the "tail.js" file of the Downloads API tests is not executed,
because the tail file is imported after the main test loop:
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#341
In order to work as expected, as part of the main test loop, the tail file
should be included directly at the end of the other tests.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #804859 -
Flags: review?(felipc)
Assignee | ||
Comment 2•11 years ago
|
||
In order for HTTP finalization to work, all the pending requests should finish.
Attachment #804859 -
Attachment is obsolete: true
Attachment #804859 -
Flags: review?(felipc)
Attachment #804865 -
Flags: review?(felipc)
Comment 3•11 years ago
|
||
Any reason to not add a call to run_next_test() on tail.js?
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to :Felipe Gomes from comment #3)
> Any reason to not add a call to run_next_test() on tail.js?
While this appears to works today, I'm not aware of any other tests that add new tasks after the main test loop has finished running, so this is likely to break in subtle ways if new state is introduced in the test runner.
Assignee | ||
Comment 5•11 years ago
|
||
And actually, we've already exited the loop in _do_main when we get there, so the finalization with run_next_test appeared to work just by chance.
You may want to repeat the test for the Places crash in bug 906134 again with this patch applied, it's possible that waiting for database finalization didn't actually work with the other approach.
Updated•11 years ago
|
Attachment #804865 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Unfortunately this conflicted with the backout of bug 913110, so a bunch of things including this, had to be backed out for now:
remote: https://hg.mozilla.org/integration/fx-team/rev/5736f23d8a22
remote: https://hg.mozilla.org/integration/fx-team/rev/fd257eef04b2
remote: https://hg.mozilla.org/integration/fx-team/rev/00593fe07777
remote: https://hg.mozilla.org/integration/fx-team/rev/ea0b23759685
remote: https://hg.mozilla.org/integration/fx-team/rev/cbc7af0a20c4
Assignee | ||
Comment 8•11 years ago
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•11 years ago
|
Attachment #804865 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/6c862ae466a5
Gavin's comment in bug 913110 comment 23 contains a general summary about the reason for tracking Firefox 26.
Updated•11 years ago
|
tracking-firefox26:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•