Closed
Bug 916606
Opened 11 years ago
Closed 11 years ago
Annotate MozConnection with [[NoInterfaceObject]]
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 952084
People
(Reporter: emk, Assigned: emk)
References
()
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
I've unprefixed the interface because it is no longer exposed on the global object.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #805387 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6e9f568e82f2
|
||
Comment 4•11 years ago
|
||
Added dev-doc-needed to check we didn't document MozConnection as visible, and to add a note on Fx XY for dev.
Keywords: dev-doc-needed
Comment on attachment 805387 [details] [diff] [review] Part 2: Remove nsIDOMMozConnection and nsIMozNavigatorNetwork Review of attachment 805387 [details] [diff] [review]: ----------------------------------------------------------------- Over to mounir
Attachment #805387 -
Flags: review?(jonas) → review?(mounir)
Comment on attachment 805386 [details] [diff] [review] Part 1: Convert MozConnection to WebIDL and unprefix it Review of attachment 805386 [details] [diff] [review]: ----------------------------------------------------------------- Over to Mounir
Attachment #805386 -
Flags: review?(jonas) → review?(mounir)
|
||
Comment 7•11 years ago
|
||
Comment on attachment 805386 [details] [diff] [review] Part 1: Convert MozConnection to WebIDL and unprefix it Review of attachment 805386 [details] [diff] [review]: ----------------------------------------------------------------- You should not make the Connection interface a [NoInterfaceObject]. The specification is simply wrong in requesting that.
Attachment #805386 -
Flags: review?(mounir)
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 805387 [details] [diff] [review] Part 2: Remove nsIDOMMozConnection and nsIMozNavigatorNetwork Please update this patch (or re-ask for a review) when you will have updated the part 1.
Attachment #805387 -
Flags: review?(mounir)
|
|
Assignee | |
Comment 9•11 years ago
|
||
(In reply to Mounir Lamouri (:mounir) from comment #7) > You should not make the Connection interface a [NoInterfaceObject]. The > specification is simply wrong in requesting that. Could you update the spec text?
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•9 years ago
|
Keywords: dev-doc-needed
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•