Closed
Bug 916729
Opened 11 years ago
Closed 11 years ago
[Async shutdown] Handle exceptions
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: Yoric, Assigned: Yoric)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Async][Async Shutdown])
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
If |condition| is a function and if its evaluation throws an error, this completely destroys AsyncShutdown. We need to fix this.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → dteller
Attachment #805242 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Same one, with the patch.
Attachment #805242 -
Attachment is obsolete: true
Attachment #805242 -
Flags: review?(nfroyd)
Attachment #805260 -
Flags: review?(nfroyd)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 805260 [details] [diff] [review]
Handle exceptions in |condition|
Review of attachment 805260 [details] [diff] [review]:
-----------------------------------------------------------------
Works for me. Can we have a testcase, too?
Attachment #805260 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Same one, with a trivial test.
Try: https://tbpl.mozilla.org/?tree=Try&rev=6fc4bb40f22c
Attachment #805260 -
Attachment is obsolete: true
Attachment #805295 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Same one, without a syntax error in the test.
Attachment #805295 -
Attachment is obsolete: true
Attachment #805295 -
Flags: review?(nfroyd)
Attachment #805368 -
Flags: review?(nfroyd)
|
||
Comment 6•11 years ago
|
||
Whiteboard: [Async][Async Shutdown] → [Async][Async Shutdown][fixed-in-fx-team]
|
|
||
Comment 7•11 years ago
|
||
Aww crap. You put the wrong bug number in the patch :(
Whiteboard: [Async][Async Shutdown][fixed-in-fx-team] → [Async][Async Shutdown]
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
|
Assignee | |
Comment 9•11 years ago
|
||
Comment on attachment 805368 [details] [diff] [review]
Handle exceptions in |condition|, v3
Since froydnj is not very available at the moment and since I have just added a few tests since the r+, I'll just carry over that r+.
Attachment #805368 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 10•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [Async][Async Shutdown] → [Async][Async Shutdown][fixed-in-fx-team]
|
|
||
Comment 11•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Async][Async Shutdown][fixed-in-fx-team] → [Async][Async Shutdown]
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•