Tim Abraldes [:TimAbraldes] [:tabraldes] Reporter
	Description • 11 years ago

This was recently discussed on the metro mailing list:
  https://mail.mozilla.org/pipermail/metro/2013-September/000282.html

We will remove the "startup" section from our options panel, and will always act as if "show tabs from last time" is selected.

	Tim Abraldes [:TimAbraldes] [:tabraldes] Reporter
	Comment 1 • 11 years ago

This is a screenshot highlighting the option that will be removed

	Brian R. Bondy [:bbondy]
	Comment 2 • 11 years ago

I agree we should remove the option, but the default option should be to show start page?

I think that the MS guideline for Metro apps is to resume the session if the app was suspended and killed, but to start fresh if the previous execution state was a fresh close.

	Asa Dotzler [:asa]
	Comment 3 • 11 years ago

Yes, I think Brian is correct.  For those users who do discover "kill it for real" we should start up fresh.  That respects the Windows guidelines and gives the user a simple "get rid of this mess and start fresh" gesture.

	Tim Abraldes [:TimAbraldes] [:tabraldes] Reporter
	Comment 4 • 11 years ago

SGTM. I see the benefit of defaulting to either option and I don't have a strong preference for one over the other

	Brian R. Bondy [:bbondy]
	Comment 5 • 11 years ago

Kamil, interested in taking this one?

	Kamil Jozwiak [:kjozwiak] Assignee
	Comment 6 • 11 years ago

Sure! Thanks Brian

	Kamil Jozwiak [:kjozwiak] Assignee
	Comment 7 • 11 years ago

Removed the "Startup" labels and menu items from the "Options" panel. Doubled checked metro.js and ensured that when Firefox Metro is killed incorrectly (crashes), that all the tabs are restored.

Went through the following test cases:
- Closed Firefox Metro (killed properly) and ensured that a "fresh slate" was used when re-launching the browser
- Closed Firefox Metro using the Task Manager (incorrect kill) and ensured that all the tabs where restored when the browser was re-launched

Please let me know if I missed something!

	Kamil Jozwiak [:kjozwiak] Assignee
	Comment 8 • 11 years ago

Forgot to mention that I left the pref there so it can be used in the future if needed but is not supported by the UI

	Matt Brubeck (:mbrubeck)
	Comment 9 • 11 years ago

Comment on attachment 814696 [details] [diff] [review]
removing "Startup" from the "Options" flyout

Review of attachment 814696 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

	Kamil Jozwiak [:kjozwiak] Assignee
	Comment 10 • 11 years ago

Thanks Matt,

Would you be able to push this to the try server if you have some time? Just let me know!

	Matt Brubeck (:mbrubeck)
	Comment 11 • 11 years ago

Metro tests passed locally; landing directly to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/10824701bc80

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/10824701bc80