Closed
Bug 917086
Opened 11 years ago
Closed 11 years ago
Disallow DIRS, PARALLEL_DIRS and TEST_DIRS under TOOL_DIRS and TEST_TOOL_DIRS
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 2 obsolete files)
Currently, it's hard to track whether a deep directory is a TOOL_DIR or TEST_TOOL_DIR, because it may be indirectly inheriting that property from one of its parent, from how the tree is traversed with the make rules. It would be clearer (and would help further changes) if subdirectories of TOOL_DIR/TEST_TOOL_DIR were explicitly marked as such. The easiest way there is to disallow DIRS, PARALLEL_DIRS and TEST_DIR there.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #805751 -
Flags: review?(mshal)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #805752 -
Flags: review?(gps)
Updated•11 years ago
|
Attachment #805752 -
Flags: review?(gps) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #805751 -
Attachment is obsolete: true
Attachment #805751 -
Flags: review?(mshal)
Assignee | ||
Comment 3•11 years ago
|
||
Also mark TOOL_DIRS/TEST_TOOL_DIRS directories in backend.mk and recurse them normally instead of forcing make -C dir libs for them.
---
So, it turns out the previous iteration was breaking the tree when not used in conjunction with bug 917086. And this was due to us recursing those directories with make libs. So now, we always recurse them with make tools.
Attachment #806363 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #805752 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #806363 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Whiteboard: with a fixup working around a make bug. r+ed on irc.
Assignee | ||
Updated•11 years ago
|
Whiteboard: with a fixup working around a make bug. r+ed on irc.
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•