The getUserDownloadsDirectory and getTemporaryDownloadsDirectory functions of the Downloads API were named after the methods of nsIDownloadManager, but now we must find new names that are more indicative of what the functions do.

I suggested getPreferredDownloadsDirectory, to replace getUser... But I don't have any good ideas for the Temporary directory so far, nothing better than temporary, at least.

Comment on attachment 807033 [details] [diff] [review] Change getUserDownloadsDirectory to getPreferredDownloadsDirectory Review of attachment 807033 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js @@ +192,1 @@ > do_check_eq(downloadDir.path, userDownloadDir.path); nit: "preferredDownloadDir"

(In reply to Marco Bonardo [:mak] from comment #1) > I suggested getPreferredDownloadsDirectory, to replace getUser... > But I don't have any good ideas for the Temporary directory so far, nothing > better than temporary, at least. We currently invoke functions called "deleteTemporaryFileOnExit" and "deleteTemporaryPrivateFileWhenPossible" on downloads that end up in that directory, so we may just keep the "getTemporaryDownloadsDirectory" name, in that it is for "temporary downloads" despite it's not necessarily the system's temporary directory.

(In reply to :Paolo Amadini from comment #3) > Comment on attachment 807033 [details] [diff] [review] > Change getUserDownloadsDirectory to getPreferredDownloadsDirectory > > Review of attachment 807033 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js > @@ +192,1 @@ > > do_check_eq(downloadDir.path, userDownloadDir.path); > > nit: "preferredDownloadDir" Addressed. Pushed to try and waiting for result https://tbpl.mozilla.org/?tree=Try&rev=63b8608acb86

Comment on attachment 808952 [details] [diff] [review] Patch for checkin Passed try. https://tbpl.mozilla.org/?tree=Try&rev=63b8608acb86

Comment on attachment 808952 [details] [diff] [review] Patch for checkin In the future, please just use checkin-needed for single-patch bugs :)