Closed Bug 917306 Opened 11 years ago Closed 11 years ago

[app manager + style editor] When connected to the market place app, no style sheets are visible if the screen is locked

Categories

(DevTools Graveyard :: WebIDE, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: paul, Assigned: paul)

Details

No description provided.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Paul, do you see no stylesheets at all? I see one, "style.css", so I wanted to confirm whether you see that or not. However, there are two more stylesheets that should be showing up. The style editor actor currently can't fetch them though, because these are remote (https) stylesheets within an iframe inside the app. On B2G, the actors run in the same context as the app itself, and so the actor is blocked from loading these sheets. It seems like we'd either need to get the actor to make the request within the context of the inner iframe, or perhaps message back up to the chrome process and do it there. I have a local hack that gets all the sheets, but only by breaking security rules, so that's not much use for real. Due to the complexity here, I don't think it makes sense for this to block App Manager v1. Debugging this issue was very educational. I learned a lot about the app security model! :D
No longer blocks: appmgr_v1
Flags: needinfo?(paul)
(In reply to J. Ryan Stinnett [:jryans] from comment #1) > Paul, do you see no stylesheets at all? > > I see one, "style.css", so I wanted to confirm whether you see that or not. I don't see anything. > However, there are two more stylesheets that should be showing up. The > style editor actor currently can't fetch them though, because these are > remote (https) stylesheets within an iframe inside the app. > > On B2G, the actors run in the same context as the app itself, and so the > actor is blocked from loading these sheets. It seems like we'd either need > to get the actor to make the request within the context of the inner iframe, > or perhaps message back up to the chrome process and do it there. > > I have a local hack that gets all the sheets, but only by breaking security > rules, so that's not much use for real. I don't understand that. Is there any mozapp or mozbrowser iframes in the market place app? What security rules are you breaking? > Due to the complexity here, I don't think it makes sense for this to block > App Manager v1. The no-style-sheet part is critical. The iframe issue is not critical. > Debugging this issue was very educational. I learned a lot about the app > security model! :D Did you get a chance to read my 2 last post on the mailing list? https://groups.google.com/d/msg/mozilla.dev.developer-tools/l3mKbG0yRn4/jiMH8EZS7hUJ https://groups.google.com/d/msg/mozilla.dev.developer-tools/2OkPQ30B6fc/GFb1nrU1fLoJ
Flags: needinfo?(paul)
(In reply to Paul Rouget [:paul] from comment #2) > (In reply to J. Ryan Stinnett [:jryans] from comment #1) > > Paul, do you see no stylesheets at all? > > > > I see one, "style.css", so I wanted to confirm whether you see that or not. > > I don't see anything. Okay, I can't reproduce this, so probably best for you to take a look then. > > Due to the complexity here, I don't think it makes sense for this to block > > App Manager v1. > > The no-style-sheet part is critical. The iframe issue is not critical. I agree, the no stylesheet issue is more critical, so I'll make this block v1 again, and file a separate bug for the less critical iframe issue. > Did you get a chance to read my 2 last post on the mailing list? > > https://groups.google.com/d/msg/mozilla.dev.developer-tools/l3mKbG0yRn4/jiMH8EZS7hUJ > https://groups.google.com/d/msg/mozilla.dev.developer-tools/2OkPQ30B6fc/GFb1nrU1fLoJ Yes, also very helpful! :D
Assignee: jryans → paul
Blocks: appmgr_v1
Hardware: x86 → All
Oh, I think I can reproduce now. Do you see the following behavior? 1. Reboot device 2. Connect via App Manager 3. Marketplace is not running 4. Start Marketplace app 5. App starts and phone screen is on 6. Debug Marketplace 7. One stylesheet ("style.css") appears in the Style Editor 8. Close the toolbox 9. Turn the phone screen off by pressing the power button on the phone 10. Debug Marketplace 11. No stylesheets shown
Turning the screen off might disable the network in some cases. So if the page is not cached, we can't get the source. Does this sound right? Is this a dupe of bug 918004?
A thing I think we should do (that would solve the problem and make the debug experience better) is to disable phone lock and screen lock while debugging.
No longer depends on: 918004
(In reply to Paul Rouget [:paul] from comment #5) > Turning the screen off might disable the network in some cases. So if the > page is not cached, we can't get the source. Does this sound right? Hmm, well, perhaps that is true in general. But I don't think that is the issue here for the first sheet, because "style.css" installed on the device (it is not remote), so it would seem strange to me for that to depend on network connectivity. > Is this a dupe of bug 918004? No. Bug 918004 is where I moved the secondary discussion of remote sheets not loading, so that this bug could be focused on the issue of getting the packaged Marketplace ("style.css") file to appear.
(In reply to J. Ryan Stinnett [:jryans] from comment #4) > Oh, I think I can reproduce now. Do you see the following behavior? > > 1. Reboot device > 2. Connect via App Manager > 3. Marketplace is not running > 4. Start Marketplace app > 5. App starts and phone screen is on > 6. Debug Marketplace > 7. One stylesheet ("style.css") appears in the Style Editor > 8. Close the toolbox > 9. Turn the phone screen off by pressing the power button on the phone > 10. Debug Marketplace > 11. No stylesheets shown I can reproduce.
Summary: [app manager + style editor] When connected to the market place app, no style sheets are visible → [app manager + style editor] When connected to the market place app, no style sheets are visible if the screen is locked
No longer blocks: appmgr_v1
Priority: -- → P1
Priority: P1 → P2
Priority: P2 → P3
I can't reproduce anymore.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.