Jim Mathies [:jimm] Reporter
	Description • 11 years ago

Most of our redraw issues in chrome seem to have gone away and the start page now uses apz. we should add this back in (if we still want it) and test.

	Sam Foster [:sfoster] (he/him) Assignee
	Comment 1 • 11 years ago

Restores our existing watermark image. Pan around the start page to see it in action. Preview: https://dl.dropboxusercontent.com/u/1719101/share/start-watermark.png

Was there anything else you wanted to see here Michael?

	Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com)
	Comment 2 • 11 years ago

Comment on attachment 8342697 [details] [diff] [review]
Put back the watermark image with background-attachment: fixed

Beautiful. Thanks, Sam.

	Rodrigo Silveira [:rsilveira] [:rodms]
	Comment 3 • 11 years ago

Comment on attachment 8342697 [details] [diff] [review]
Put back the watermark image with background-attachment: fixed

Review of attachment 8342697 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/theme/platform.css
@@ +638,5 @@
>    background-color: @panel_light_color@;
> +  background-image: url("chrome://browser/skin/images/firefox-watermark.png");
> +  background-repeat: no-repeat;
> +  background-position: center center;
> +  background-attachment: fixed;

Alternatively you can use the shorthand background: url() no-repeat fixed center center @panel_light_color@;

This is probably more readable though.

	Sam Foster [:sfoster] (he/him) Assignee
	Comment 4 • 11 years ago

Yeah I started with the backout of the original patch, which had the properties spelled out this way. Its is overly verbose maybe. 
Landed on fx-team as-is though: 
https://hg.mozilla.org/integration/fx-team/rev/cea439ce0f0d

	Marco Mucci [:MarcoM]
	Comment 5 • 11 years ago

Hey Sam, can you provide a point value and I'll add this to the iteration.  Thanks.

	Carsten Book [:Tomcat]
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/cea439ce0f0d

	Sam Foster [:sfoster] (he/him) Assignee
	Comment 7 • 11 years ago

this is a 1 pointer

	Marco Mucci [:MarcoM]
	Comment 8 • 11 years ago

Temporarily reopening to add to IT#20.  Will resolve right after.

	Manuela Muntean [Away]
	Comment 9 • 11 years ago

Verified as fixed, for iteration #20, with latest Nightly (build ID: 20131209053402) on Win 8 64-bit: the watermark image is visible on the start page.