Jeff pointed out that the Simulator start button is not very clear as a "Launch" button since it is gray, and displays the internal name of the add-on without an action verb in front of it. We should use the blue color like "Connect" etc., and use a pretty name for the add-on if possible.

We should add "Start: ", exactly like in the adb helper connection section ("Connect to:").

(not critical for 26)

Hi Paul I've done some initial work on this bug, but not quite sure if it's what you want. Please take a look.

Comment on attachment 820397 [details] [diff] [review] Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch Just rename startThisSimulator to startSimulator, and then I think we can land that :) Thanks!

There's already startSimulator been defined: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/app-manager.dtd#45 But seems unused: http://mxr.mozilla.org/mozilla-central/search?string=connection.startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central Did you mean ? <!ENTITY connection.startSimulator "Start Simulator"> ==> <!ENTITY connection.startSimulator "Start:"> (In reply to Paul Rouget [:paul] from comment #6) > Comment on attachment 820397 [details] [diff] [review] > Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch > > Just rename startThisSimulator to startSimulator, and then I think we can > land that :) > > Thanks!

I would like to work on this bug, can you assign it to me.

(In reply to taj from comment #8) > I would like to work on this bug, can you assign it to me. Taj, this bug already has a patch and is nearly done. Check out the good first bug list for other ones to pick from: https://wiki.mozilla.org/DevTools/GetInvolved#Mentored_and_Good_First_Bugs

(In reply to i from comment #7) > There's already startSimulator been defined: > http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/ > browser/devtools/app-manager.dtd#45 > > But seems unused: > http://mxr.mozilla.org/mozilla-central/search?string=connection. > startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozill > a-central > > Did you mean ? > <!ENTITY connection.startSimulator "Start Simulator"> ==> <!ENTITY > connection.startSimulator "Start:"> > > (In reply to Paul Rouget [:paul] from comment #6) > > Comment on attachment 820397 [details] [diff] [review] > > Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch > > > > Just rename startThisSimulator to startSimulator, and then I think we can > > land that :) > > > > Thanks! Oh I was wrong about this, actually connection.startSimulator was defined AND in use: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/app-manager/content/connection-footer.xhtml#54 https://bug917617.bugzilla.mozilla.org/attachment.cgi?id=821416

(In reply to i from comment #11) > (In reply to i from comment #7) > > There's already startSimulator been defined: > > http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/ > > browser/devtools/app-manager.dtd#45 > > > > But seems unused: > > http://mxr.mozilla.org/mozilla-central/search?string=connection. > > startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozill > > a-central > > > > Did you mean ? > > <!ENTITY connection.startSimulator "Start Simulator"> ==> <!ENTITY > > connection.startSimulator "Start:"> > > > > (In reply to Paul Rouget [:paul] from comment #6) > > > Comment on attachment 820397 [details] [diff] [review] > > > Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch > > > > > > Just rename startThisSimulator to startSimulator, and then I think we can > > > land that :) > > > > > > Thanks! > > Oh I was wrong about this, > actually connection.startSimulator was defined AND in use: > > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/app-manager/ > content/connection-footer.xhtml#54 > https://bug917617.bugzilla.mozilla.org/attachment.cgi?id=821416 Good catch. So I guess startThisSimulator is good.

Well… maybe not. Let's call that: `startRegisteredSimulator`.

(In reply to Paul Rouget [:paul] from comment #13) > Well… maybe not. Let's call that: `startRegisteredSimulator`. Good ideal :)

Thank you Li!

(In reply to Paul Rouget [:paul] from comment #16) > Thank you Li! :)

Thank you for the patch! :-) https://hg.mozilla.org/integration/fx-team/rev/5615aa677b90

(In reply to Ed Morley [:edmorley UTC+1] from comment #18) > Thank you for the patch! :-) > > https://hg.mozilla.org/integration/fx-team/rev/5615aa677b90 :)