Closed
Bug 917622
Opened 11 years ago
Closed 11 years ago
Use INSTALL_TARGETS for mochitests
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
On the longer term, this should use install manifests, but that'd require more effort than i'm willing to put right now (moving MOCHITEST_* variables to moz.build, etc., and dealing with bug 911375)
Hopefully, this will solve the weird issues i'm having on try with bug 907365.
Assignee | ||
Comment 1•11 years ago
|
||
While there, i removed the relativesrcdir check, since it's now essentially set everywhere.
Attachment #806368 -
Flags: review?(gps)
Comment 2•11 years ago
|
||
Comment on attachment 806368 [details] [diff] [review]
Use INSTALL_TARGETS for mochitests
Review of attachment 806368 [details] [diff] [review]:
-----------------------------------------------------------------
I thought we created the _A, etc targets because of extra long command names. I believe INSTALL_TARGETS commands everything on the same command invocation. So we might be in for a bad time when this lands.
Attachment #806368 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #2)
> I thought we created the _A, etc targets because of extra long command
> names. I believe INSTALL_TARGETS commands everything on the same command
> invocation. So we might be in for a bad time when this lands.
INSTALL_TARGETS doesn't do everything in one command.
Assignee | ||
Comment 4•11 years ago
|
||
Whiteboard: With removed duplicates, missed stuff, and new stuff, r+ed on irc.
Assignee | ||
Updated•11 years ago
|
Whiteboard: With removed duplicates, missed stuff, and new stuff, r+ed on irc.
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Comment 6•11 years ago
|
||
This broke Nightly builds:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28423679&tree=Mozilla-Central&full=1#error0
Yeah, WTF pymake. Good news is we can work around it by converting offending directories to manifests.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•