Marek Wawoczny Reporter
	Description • 23 years ago

Localization problems with Bookmarks "Sorted By" menu & History "Sorted By" menu.
"Sorted by" menu gets strings from headers - wrong (can't localize it in proper
way). It should have own strings as for example in mail client.

Strings are from:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/locale/en-US/bookmarks.dtd#68
 to #74

Instead of gettings labels from headers add labels like this:
sortedby.name.label
sortedby.url.label
etc.

	nhottanscp
	Comment 1 • 23 years ago

Reassign to vishy, cc to l10n.

	Paul Chen
	Comment 2 • 23 years ago

nav triage team:

marking p3, mozilla0.9.5, reassigning to ben

	Paul Chen
	Comment 3 • 23 years ago

nav triage team:

Forgot nsbeta1+

	Andreas Becker
	Comment 4 • 23 years ago

mass change, switching qa contact from jonrubin to ruixu.

	Jaime Rodriguez, Jr.
	Comment 5 • 23 years ago

Paul/Ben - You nsbeta1+ this one. Should we assume it is worthy of nsbranch+?
Will this get fixed this week?

	Cindy Roberts
	Comment 6 • 23 years ago

Marking nsbranch- as it was decided in the August bug triage that we wouldn't
have enough time in eMojo to fix this.  Let's revisit for MachV.

	Peter Trudelle
	Comment 7 • 23 years ago

removing redundant nsbranch keyword, ->0.9.6

	Ben Goodger (use ben at mozilla dot org for email)
	Comment 8 • 23 years ago

This set of menu items is dynamically generated. You should not have a problem
creating the appropriate localized phrasing as the string that forms a template
for the items is:

SortMenuItem = Sorted by %NAME%

in English..

where %NAME% is replaced by whatever we're sorting by. 

If a language positions %NAME% differently, you can change that, e.g.

SortMenuItem = %NAME% blah blah

or

blah %NAME% blah

	Marek Wawoczny Reporter
	Comment 9 • 23 years ago

Uhm ehm... I know how to localize it -I've localized whole Mozilla...
As I said - labels are taken from headers - wrong:
In English:
Header - "Location"
Sort by menu - "Sorted by Location"

Thats ok.

But in Polish:
Header - "Adres"
Sort by menu - "Posortowane wedlug Adresu"

U see - Got "Adres" in headers but "Adresu" in sort by menu.
Of course I can make:

"Posortowane wedlug: Adres"

But this looks ugly, and this form isn't used in Polish language.

So this bug is not worksforme.

	Marek Wawoczny Reporter
	Comment 10 • 23 years ago

Reopening bug

	Ben Goodger (use ben at mozilla dot org for email)
	Comment 11 • 23 years ago

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

	Paul Chen
	Comment 12 • 23 years ago

mass moving mozilla0.9.6 bugs to mozilla0.9.7

	Paul Chen
	Comment 13 • 23 years ago

Moving to mozilla0.9.9 since I don't think I'll have any time to take a look at
this soon, adding helpwanted

	Paul Chen
	Comment 14 • 23 years ago

Pushing out to mozilla1.0.1

	Peter Trudelle
	Comment 15 • 23 years ago

mass reassign of pchen bookmark bugs to ben

	Vedran Miletic
	Comment 16 • 21 years ago

retargeting

	Olivier Mengué
	Comment 17 • 20 years ago

I think this bug could be marked fixed now, as bookmarks.dtd doesn't include the
labels anymore.

	Marek Stępień [:marcoos, inactive]
	Comment 18 • 18 years ago

(In reply to comment #17)
> I think this bug could be marked fixed now, as bookmarks.dtd doesn't include
> the labels anymore.

...in SeaMonkey.

It does in Firefox and Marek's comment 9 is still justified for many non-English locales.

Moving this to the Firefox component.

	Mats Palmgren (inactive) Assignee
	Comment 19 • 18 years ago

Marek, would something like this solve the problem?

	Marek Stępień [:marcoos, inactive]
	Comment 20 • 18 years ago

Yes, for the Places part.

If the old-style bookmarks are really going to be removed in 3.0, this should fix the issue completely.

If not, a similar patch for the old-style bookmarks is also needed.

	Asaf Romano (gone)
	Comment 22 • 18 years ago

Comment on attachment 238213 [details] [diff] [review]
Patch A, rev.1 (Places)

Hrm? How is "E" an accesskey for "Sort by Title" for example? Also note accesskeys are case-sensitive..

	Robert Kaiser
	Comment 23 • 18 years ago

accesskeys ar _not_ case-sensitive by themselves. If there's no match for the exact case, the first character that matches a case-insensitive search is taken.

	Asaf Romano (gone)
	Comment 25 • 18 years ago

The question remains though, how is "e" a good acesskey in this case (this is the _last_ character)?

	Mats Palmgren (inactive) Assignee
	Comment 26 • 18 years ago

(In reply to comment #25)
> The question remains though, how is "e" a good acesskey in this case

I read somewhere (sorry, can't remember where) that one should avoid words
that is part of a common leading prefix. In our case "Sort by":
Sort by Title
Sort by Location
Sort by Visit Date
Sort by Visit Count

For "Title", "T" is already used by "Toolbar" and "l" is already used by
"Reload", this leaves "i" and "e". Single pixel letters like "l" and "i"
should be avoided if possible (hard to see underline), so I chose "e".

	Asaf Romano (gone)
	Comment 27 • 18 years ago

Suggesting:
R&eload
T&oolbar
&Show Columns
--
&Unsorted
Sort by &Title
Sort by &Location
Sort by &Visit Date
Sort By Visit &Count

However, the places ui is going to be completely redesigned, and we'll probably enable it for Fx3. You may want to wait until then...

	Mats Palmgren (inactive) Assignee
	Comment 28 • 18 years ago

The accesskeys you suggested above, except I used 'R' for Reload - it doesn't
clash with anything on the View menu or context menus AFAICT...

	Asaf Romano (gone)
	Comment 29 • 18 years ago

Comment on attachment 241820 [details] [diff] [review]
Patch rev. 3 (Places)

OK, please file a bug on adding accesskeys to the context menu.

r=mano.

	Mats Palmgren (inactive) Assignee
	Comment 30 • 18 years ago

(In reply to comment #29)
> (From update of attachment 241820 [details] [diff] [review] [edit])
> OK, please file a bug on adding accesskeys to the context menu.

Already filed, bug 322239

> r=mano.

Does that cover the old-style Bookmarks Manager patch as well?

	Asaf Romano (gone)
	Comment 31 • 18 years ago

No, I'll review it some-time soon (read: next week at worse).

	Asaf Romano (gone)
	Comment 32 • 18 years ago

Comment on attachment 241612 [details] [diff] [review]
Patch B, rev. 1 (Bookmarks)

Assuming you've tested this, r=mano.

	Mats Palmgren (inactive) Assignee
	Comment 33 • 18 years ago

Yes, I tested both patches.

Both patches checked in to trunk at 2006-11-08 19:03 PDT.

-> FIXED

	Marek Stępień [:marcoos, inactive]
	Comment 34 • 18 years ago

Mats, thank you very much for this. :)

	Gervase Markham [:gerv]
	Comment 35 • 15 years ago

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv