USE_LIBUNWIND has been removed from m-c, but it's still present in b2g18, and is breaking the profiler. I will post a patch to remove this from b2g18 as well. Although this might seem late in the game to land a b2g18 patch, this should be high priority since we're being asked to resolve a lot of start-up time regressions between v1.1 and v1.2.

Builds/runs/works locally; unfortunately there is no b2g18-only try server I can bounce this off of.

Comment on attachment 806718 [details] [diff] [review] remove USE_LIBUNWIND and dependencies from profiler Review of attachment 806718 [details] [diff] [review]: ----------------------------------------------------------------- does the libunwind code get built on b2g as well? http://mxr.mozilla.org/mozilla-b2g18/source/tools/profiler/Makefile.in#30 Avoiding this is the real saving.

Ohh I see, you have an enable-profiling build. We wont be shipping it with normal builds. The b2g profiler doesn't yet benefit from enable-profiling builds since it doesn't use the information yet.

Comment on attachment 806762 [details] [diff] [review] remove USE_LIBUNWIND and dependencies from profiler Review of attachment 806762 [details] [diff] [review]: ----------------------------------------------------------------- ::: tools/profiler/Makefile.in @@ +28,5 @@ > $(NULL) > > ifneq (,$(MOZ_PROFILING)) > ifneq (,$(filter Android,$(OS_TARGET))) > +ifneq (gonk,$(MOZ_WIDGET_TOOLKIT)) Remove this and the define was the most important. I didn't really mean it was worth ripping out the code but its fine. I guess there's no point in hg rm libunwind under the b2g18 since its done on central.

(In reply to Benoit Girard (:BenWa) from comment #5) > Remove this and the define was the most important. I didn't really mean it removing*

Comment on attachment 806762 [details] [diff] [review] remove USE_LIBUNWIND and dependencies from profiler NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a User impact if declined: unable to use the profiler on b2g18 builds, unable to compare v1.1 builds to later ones Testing completed: been in use for a week Risk to taking this patch (and alternatives if risky): none; libunwind was removed from later builds anyway String or UUID changes made by this patch: none

Similar question as what's shown - https://bugzilla.mozilla.org/show_bug.cgi?id=799638#c48, why can't a local application of this patch on b2g18 be sufficient here? Why do we need this patch on b2g18 directly?

Also, what is the customer impact if this in not uplifted in b2g18?

fxos-perf-triage: We don't see a need to leo? this. We have an email thread with Mike H discussing the motivation for leo?. this bug will be updated based on that thread's conclusion or Mike H's response to this bug's needinfo.

de-noming. As mentioned in bug 799638, I'm going to ball all of these profiling patches up into one that can be applied to gecko to make profiling work; devs can apply it as needed.

Comment on attachment 806762 [details] [diff] [review] remove USE_LIBUNWIND and dependencies from profiler a- on b2g18 per https://bugzilla.mozilla.org/show_bug.cgi?id=917892#c11

Firefox OS is not being worked on