Closed
Bug 918160
Opened 11 years ago
Closed 9 years ago
Set.js contains lots of .call()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 987243
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
I think all these need to be replaced with callFunction.
|
Assignee | |
Comment 1•11 years ago
|
||
Lest I get pegged with the review I'm taking this.
Assignee: general → jorendorff
|
|
Assignee | |
Comment 2•11 years ago
|
||
This patch changes the error message when you do something silly like:
js> var obj = new Date;
js> obj.forEach = Map.prototype.forEach;
js> obj.forEach(_ => _)
typein:3:0 TypeError: entries method called on incompatible Date
It used to say "unknown type object".
Attachment #807714 -
Flags: review?(till)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 807714 [details] [diff] [review]
v1
Review of attachment 807714 [details] [diff] [review]:
-----------------------------------------------------------------
There's nothing not to love about this.
Attachment #807714 -
Flags: review?(till) → review+
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•