Closed
Bug 918164
Opened 11 years ago
Closed 11 years ago
Add -FS option to NSS config when using VS2013
Categories
(NSS :: Build, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15.5
People
(Reporter: m_kato, Assigned: ehsan.akhgari)
References
Details
Attachments
(3 files)
(deleted),
patch
|
briansmith
:
review+
briansmith
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
briansmith
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
briansmith
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
see bug 915973.
Reporter | ||
Updated•11 years ago
|
Summary: Add -FS option when using VS2013 → Add -FS option to NSS config when using VS2013
Comment 1•11 years ago
|
||
I have reported Bug 932171? which seems related to NSS and /FS option when building debug builds.
Comment 2•11 years ago
|
||
Patch to add -FS to VS2013 and greater.
We should check this in; who can r+?
Assignee | ||
Updated•11 years ago
|
Attachment #832069 -
Flags: review?(brian)
Updated•11 years ago
|
Assignee: nobody → ehsan
Target Milestone: --- → 3.15.5
Comment 6•11 years ago
|
||
Comment on attachment 832069 [details] [diff] [review]
918164.patch
Review of attachment 832069 [details] [diff] [review]:
-----------------------------------------------------------------
I tested this both in the standalone NSS tree and a Gecko build tree. It doesn't seem to have any effect in the standalone NSS tree (i.e. doesn't seem to make things notably slower) and it does fix the build issue with VS2013 that we have in the Gecko tree.
::: security/nss/coreconf/WIN32.mk
@@ +174,5 @@
> -we4064 -we4078 -we4087 -we4090 -we4098 -we4390 -we4551 -we4553 -we4715
> +
> + ifeq ($(_MSC_VER_GTE18),1)
> + OS_CFLAGS += -FS
> + endif
There's an extra space before "ifeq" and tab+spaces instead of tab+tab before OS_CFLAGS += -FS. I will correct both of those issues when I check in the patch.
Attachment #832069 -
Flags: review?(brian) → review+
Comment 7•11 years ago
|
||
Attachment #8358889 -
Flags: checked-in+
Updated•11 years ago
|
Attachment #832069 -
Flags: checked-in+
Comment 8•11 years ago
|
||
http://hg.mozilla.org/projects/nss/rev/56dcda67db44
http://hg.mozilla.org/projects/nss/rev/ebe34884a3a0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
1. Change "GTE" to "GE" because 'ge' is the common "greater-than-or-equal"
in scripting languages.
2. Fix indentation.
I've checked in the patch to save time:
https://hg.mozilla.org/projects/nss/rev/4db08249d5a1
Please do a post-commit review. Thanks.
Attachment #8361187 -
Flags: review?(brian)
Attachment #8361187 -
Flags: checked-in+
Updated•11 years ago
|
Attachment #8361187 -
Flags: review?(brian) → review+
Updated•11 years ago
|
Target Milestone: 3.15.5 → 3.16
Updated•11 years ago
|
Priority: -- → P2
Target Milestone: 3.16 → 3.15.5
You need to log in
before you can comment on or make changes to this bug.
Description
•