Closed
Bug 918175
Opened 11 years ago
Closed 11 years ago
Use write-ahead logging for cache.sqlite on calendar sync to avoid long Thunderbird locks/delays with high IO
Categories
(Calendar :: Provider: Local Storage, defect)
Calendar
Provider: Local Storage
Tracking
(Not tracked)
RESOLVED
FIXED
2.9
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
When I synchronise my calendars, Thunderbird locks up for ~7 seconds, with hundreds of disk I/O operations. With WAL enabled, this reduces to 1.5s, the I/O count halves and the UI remains responsive. Compare: http://people.mozilla.org/~bgirard/cleopatra/#report=fda2c960e3d39baf9dd0d92e5a77eefb9df6645a http://people.mozilla.org/~bgirard/cleopatra/#report=3320e96af8c9c740c383e7c407c906800dce2f29
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #807031 -
Flags: review?(philipp)
Comment 2•11 years ago
|
||
Comment on attachment 807031 [details] [diff] [review] 918175-1.diff What a nice one-liner! Do you think this is safe enough to push for a 2.6.1 ?
Attachment #807031 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/04103ea0459e (In reply to Philipp Kewisch [:Fallen] from comment #2) > Comment on attachment 807031 [details] [diff] [review] > 918175-1.diff > > What a nice one-liner! Do you think this is safe enough to push for a 2.6.1 ? I think the risk is low enough, but check the reward is worth it. I've only got the one setup to test it on.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 2.9
Comment 4•11 years ago
|
||
awesome. May you fix many more bugs :)
Updated•11 years ago
|
Component: General → Provider: Local Storage
You need to log in
before you can comment on or make changes to this bug.
Description
•