Closed Bug 918175 Opened 11 years ago Closed 11 years ago

Use write-ahead logging for cache.sqlite on calendar sync to avoid long Thunderbird locks/delays with high IO

Categories

(Calendar :: Provider: Local Storage, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

When I synchronise my calendars, Thunderbird locks up for ~7 seconds, with hundreds of disk I/O operations. With WAL enabled, this reduces to 1.5s, the I/O count halves and the UI remains responsive.

Compare:
http://people.mozilla.org/~bgirard/cleopatra/#report=fda2c960e3d39baf9dd0d92e5a77eefb9df6645a
http://people.mozilla.org/~bgirard/cleopatra/#report=3320e96af8c9c740c383e7c407c906800dce2f29
Attached patch 918175-1.diff (deleted) — Splinter Review
Attachment #807031 - Flags: review?(philipp)
Comment on attachment 807031 [details] [diff] [review]
918175-1.diff

What a nice one-liner! Do you think this is safe enough to push for a 2.6.1 ?
Attachment #807031 - Flags: review?(philipp) → review+
https://hg.mozilla.org/comm-central/rev/04103ea0459e

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 807031 [details] [diff] [review]
> 918175-1.diff
> 
> What a nice one-liner! Do you think this is safe enough to push for a 2.6.1 ?

I think the risk is low enough, but check the reward is worth it. I've only got the one setup to test it on.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 2.9
awesome.  May you fix many more bugs :)
Blocks: 441710
Keywords: perf
Summary: Use write-ahead logging for cache.sqlite → Use write-ahead logging for cache.sqlite on calendar sync to avoid long Thunderbird locks/delays with high IO
Component: General → Provider: Local Storage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: