Closed Bug 918192 Opened 11 years ago Closed 11 years ago

[email] POP3 support: Port Thunderbird POP3 fake-server to mail-fakeservers

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.3 Sprint 3 - 10/25

People

(Reporter: asuth, Assigned: mcav)

References

Details

Attachments

(1 file)

Thunderbird has a POP3 fake-server that we should be able to integrate with our existing fake-server implementations pretty easily. Although for bug 916080 we really only need authentication, I think we can get most of it from this.
Assignee: nobody → mcav
Target Milestone: --- → 1.3 Sprint 3 - 10/25
Attached file mail-fakeservers pull request (deleted) —
Attachment #828419 - Flags: review?(bugmail)
(Also see bug 832924, where the GELAM and Gaia pull requests live)
Comment on attachment 828419 [details] mail-fakeservers pull request Awesome. One glitch though; you did break some ActiveSync tests. You need to make this fix: diff --git a/xpcom/subscript/mime.jsm b/xpcom/subscript/mime.jsm index 7755819..174bceb 100644 --- a/xpcom/subscript/mime.jsm +++ b/xpcom/subscript/mime.jsm @@ -12,7 +12,7 @@ Components.utils.import("resource://fakeserver/modules/mimeParser.jsm"); */ this.convertRfc2822RepToMessageRep = function convertRfc2822RepToMessageRep(mimestr) { - if (mimestr instanceof Uint8Array) + if (typeof(mimestr) !== 'string') mimestr = String.fromCharCode.apply(undefined, mimestr); The reason is a new (to you) and exciting foot-gun you might not be familiar with: each JSM file gets its own set of globals which breaks instanceof. It worked before when the code was in activesync_server.js because they had the same global. (nb: We probably should be using TextDecoder there too, but it was that way before so let's just leave it for now.) Anywho, please make that change, bump the revision to 0.0.7 and push a new release to npm. Since the tests pass with this updated version, we might as well land it immediately.
Attachment #828419 - Flags: review?(bugmail) → review+
Awesome, that's pretty obscure. Glad to see all the tests green again. Landed in mail-fakeservers, version-bumped to 0.0.7 on npm: https://github.com/mozilla-b2g/mail-fakeservers/commit/5c761c45aa92492fe1ec44c23288dad59884089d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: