Closed
Bug 918347
Opened 11 years ago
Closed 11 years ago
[contacts] refactor CSS to support improve load time
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)
Tracking
(blocking-b2g:-)
People
(Reporter: bkelly, Unassigned)
References
Details
(Keywords: perf, Whiteboard: [c=progress p= s=2014.04.25 u=])
Bug 918174 made the quick and easy fix to avoid style recomputations when lazy loading CSS in contacts. We should spend more time, however, to determine if the app can be refactored to better defer these loads. For example, can the progress.css be deferred until the first time a progress overlay is needed, etc.
In addition, we should investigate using scoped styles where possible to minimize the recomputations that are needed when the style sheets are loaded.
Reporter | ||
Comment 1•11 years ago
|
||
It does seem that bug 918174 regressed opening a single contact via web activity (e.g. from call log). We may want to prioritize this for 1.2.
Comms team, what do you think? Are you open to this kind of refactoring given the other work going on at the moment?
blocking-b2g: --- → koi?
Comment 2•11 years ago
|
||
my advice here is to backout bug 918174. Major refactoring work should happen in 1.3 and not in 1.2
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Jose M. Cantera from comment #2)
> my advice here is to backout bug 918174. Major refactoring work should
> happen in 1.3 and not in 1.2
Ok. I'll do the backout. Are you open to an intermediate solution that moves the CSS loads around without too much refactoring? (I know that's hard to answer without seeing patches...)
Comment 4•11 years ago
|
||
I'm open to patches provided the demosntrate a clear performance win
Updated•11 years ago
|
Whiteboard: [c= p= s= u=]
Reporter | ||
Comment 5•11 years ago
|
||
So bug 918174 was backed out, but then I investigated the regression and realized it was not actually there. So in the end bug 918174 did land.
Leaving this bug open to track possibly refactoring the CSS loading in the future. Dropping koi? nom based on comment 2.
blocking-b2g: koi? → ---
Whiteboard: [c= p= s= u=]
Reporter | ||
Updated•11 years ago
|
Whiteboard: [c= p= s= u=]
Reporter | ||
Comment 6•11 years ago
|
||
Updating title to reflect that this is more about refactoring the style sheets to improve load times.
Summary: [contacts] consider using scoped styles with lazy loaded css → [contacts] refactor CSS to support improve load time
Comment 7•11 years ago
|
||
are we going to nom this for v1.3?
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to Jose M. Cantera from comment #7)
> are we going to nom this for v1.3?
It sounds like that may be a good idea along with potentially other perf related refactoring. Is 1.3 a good time to do that? I guess nom'ing is the way to answer that.
Thanks!
blocking-b2g: --- → 1.3?
Comment 9•11 years ago
|
||
fxos-perf-triage: David, theses changes would be significant for the Contacts app so the Comms Apps team should make the call on whether to 1.3+ this. Please assign someone and decide whether to + or - this for 1.3.
Flags: needinfo?(dscravaglieri)
Whiteboard: [c= p= s= u=] → [c= p= s= u=][perf-reviewed]
Comment 10•11 years ago
|
||
Jose, what's your advice on this ?
Flags: needinfo?(noef)
Flags: needinfo?(jmcf)
Flags: needinfo?(dscravaglieri)
Updated•11 years ago
|
Flags: needinfo?(noef)
Comment 12•11 years ago
|
||
triage: not blocking 1.3 release. please land in master when ready. thanks
blocking-b2g: 1.3? → -
Updated•11 years ago
|
Whiteboard: [c= p= s= u=][perf-reviewed] → [c= p= s= u=]
Updated•11 years ago
|
Priority: -- → P3
Reporter | ||
Comment 13•11 years ago
|
||
Based on the investigation Doug did in bug 996776 I think we can probably mark this WONTFIX as well.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Updated•11 years ago
|
Whiteboard: [c= p= s= u=] → [c=progress p= s=2014.04.25 u=]
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•