Comment on attachment 807261 [details] [diff] [review] Fixes some small fallouts from the changes we've made in each page Looks good. Please test this once on 10" tablets too.

Comment on attachment 807429 [details] [diff] [review] Move and update header divider code to TopSitesPage Review of attachment 807429 [details] [diff] [review]: ----------------------------------------------------------------- I was writing a patch for this and got bored :P

Comment on attachment 807430 [details] [diff] [review] Remove unnecessary extra touch handling from BookmarksListView Review of attachment 807430 [details] [diff] [review]: ----------------------------------------------------------------- Please remove any unnecessary imports (like MotionEvent). r+ with that.

http://hg.mozilla.org/projects/fig/rev/2509e8c6f1f7 http://hg.mozilla.org/projects/fig/rev/8547dd3fbea3 http://hg.mozilla.org/projects/fig/rev/c93e65e83997

Setting to track 26, since this is part of the follow-up work to bug 917394.

https://hg.mozilla.org/mozilla-central/rev/2509e8c6f1f7 https://hg.mozilla.org/mozilla-central/rev/8547dd3fbea3 https://hg.mozilla.org/mozilla-central/rev/c93e65e83997

Comment on attachment 807261 [details] [diff] [review] Fixes some small fallouts from the changes we've made in each page [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 862793 (the new about:home UI) User impact if declined: This is part of a series of (high priority) UI changes that we'd like to get in for Firefox 26. Here's a summary: * History and Top Sites are separate pages again * Thumbnails in the Top Sites page (instead of Bookmarks page) * When entering Home, Top Sites is always the default page Testing completed (on m-c, etc.): This patch has been in our Nightly builds for almost a week now. No obvious regressions found. UI tests have been updated accordingly (see bug 917398). Risk to taking this patch (and alternatives if risky): There is some level of risk involved here as this is not a trivial change. However, we've agreed that these changes are important enough to be worth the risk. We'd like to avoid shipping a rather big UI change in Firefox 26 to then change it all over again in the following release as this would be a too disruptive experience for our users. Given the risk involved and the fact that we're adding/changing strings, it's important to have these patches uplifted as soon as possible. String or IDL/UUID changes made by this patch: n/a This is part of new-new-abouthome (see bug 917394)

Comment on attachment 807429 [details] [diff] [review] Move and update header divider code to TopSitesPage [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 862793 (the new about:home UI) User impact if declined: This is part of a series of (high priority) UI changes that we'd like to get in for Firefox 26. Here's a summary: * History and Top Sites are separate pages again * Thumbnails in the Top Sites page (instead of Bookmarks page) * When entering Home, Top Sites is always the default page Testing completed (on m-c, etc.): This patch has been in our Nightly builds for almost a week now. No obvious regressions found. UI tests have been updated accordingly (see bug 917398). Risk to taking this patch (and alternatives if risky): There is some level of risk involved here as this is not a trivial change. However, we've agreed that these changes are important enough to be worth the risk. We'd like to avoid shipping a rather big UI change in Firefox 26 to then change it all over again in the following release as this would be a too disruptive experience for our users. Given the risk involved and the fact that we're adding/changing strings, it's important to have these patches uplifted as soon as possible. String or IDL/UUID changes made by this patch: n/a This is part of new-new-abouthome (see bug 917394)

Comment on attachment 807430 [details] [diff] [review] Remove unnecessary extra touch handling from BookmarksListView [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 862793 (the new about:home UI) User impact if declined: This is part of a series of (high priority) UI changes that we'd like to get in for Firefox 26. Here's a summary: * History and Top Sites are separate pages again * Thumbnails in the Top Sites page (instead of Bookmarks page) * When entering Home, Top Sites is always the default page Testing completed (on m-c, etc.): This patch has been in our Nightly builds for almost a week now. No obvious regressions found. UI tests have been updated accordingly (see bug 917398). Risk to taking this patch (and alternatives if risky): There is some level of risk involved here as this is not a trivial change. However, we've agreed that these changes are important enough to be worth the risk. We'd like to avoid shipping a rather big UI change in Firefox 26 to then change it all over again in the following release as this would be a too disruptive experience for our users. Given the risk involved and the fact that we're adding/changing strings, it's important to have these patches uplifted as soon as possible. String or IDL/UUID changes made by this patch: n/a This is part of new-new-abouthome (see bug 917394)

https://hg.mozilla.org/releases/mozilla-aurora/rev/74ae5aed92b3 https://hg.mozilla.org/releases/mozilla-aurora/rev/92f0f575ff07 https://hg.mozilla.org/releases/mozilla-aurora/rev/0fcd50e19460