Closed Bug 918479 Opened 11 years ago Closed 11 years ago

Remove listeners from a message manager if the child side dies

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: ferjm, Assigned: smaug)

Details

(Keywords: perf, Whiteboard: [c=memory p= s= u=] [MemShrink])

Attachments

(1 file)

In order to do a proper clean up of message managers, we could add some kind of listener ID that the parent side could keep track of so when a child side dies the parent could remove the listeners added from that child.
I'd be happy to implement this if someone proposes an easy to use API which doesn't break backwards compatibility. So, ideas are welcome.
So we are probably leaking in the parent when children are killed by the OOM killer? If so that's really bad and we need to fix this as soon as possible.
Whiteboard: [MemShrink]
So we do clear process message managers already. Patch coming to do the same thing for frame message managers.
Assignee: nobody → bugs
Attached patch patch (deleted) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=a7916df4a129 Crossing fingers try looks ok. It should.
Attachment #817278 - Flags: review?(fabrice)
Attachment #817278 - Flags: review?(fabrice) → review+
Status: NEW → ASSIGNED
Keywords: perf
Whiteboard: [MemShrink] → [c=memory p= s= u=] [MemShrink]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: