Closed
Bug 918479
Opened 11 years ago
Closed 11 years ago
Remove listeners from a message manager if the child side dies
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ferjm, Assigned: smaug)
Details
(Keywords: perf, Whiteboard: [c=memory p= s= u=] [MemShrink])
Attachments
(1 file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
In order to do a proper clean up of message managers, we could add some kind of listener ID that the parent side could keep track of so when a child side dies the parent could remove the listeners added from that child.
Assignee | ||
Comment 1•11 years ago
|
||
I'd be happy to implement this if someone proposes an easy to use API which doesn't break backwards compatibility. So, ideas are welcome.
Comment 2•11 years ago
|
||
So we are probably leaking in the parent when children are killed by the OOM killer? If so that's really bad and we need to fix this as soon as possible.
Updated•11 years ago
|
Whiteboard: [MemShrink]
Assignee | ||
Comment 3•11 years ago
|
||
So we do clear process message managers already.
Patch coming to do the same thing for frame message managers.
Assignee: nobody → bugs
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=a7916df4a129
Crossing fingers try looks ok. It should.
Attachment #817278 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #817278 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•